Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement string comparsions in the JIT #211

Open
nbhuiyan opened this issue Jul 27, 2018 · 0 comments
Open

Implement string comparsions in the JIT #211

nbhuiyan opened this issue Jul 27, 2018 · 0 comments
Assignees

Comments

@nbhuiyan
Copy link
Member

Option 1: Replace std::string with internal string type (complex). This gives us a known layout for string, which would allow us to work directly with the underlying character array.
Option 2: Dispatch to a string comparison jit helper where operands are Values. (easy) Do a string looking up the helper, not in the generated code.

Will go with option 2 unless people have other ideas.

@nbhuiyan nbhuiyan self-assigned this Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant