Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Some browser show disabled links #436

Open
JannikStreek opened this issue Oct 18, 2024 · 2 comments
Open

Bug: Some browser show disabled links #436

JannikStreek opened this issue Oct 18, 2024 · 2 comments
Assignees
Labels
type-bug Something isn't working

Comments

@JannikStreek
Copy link
Member

JannikStreek commented Oct 18, 2024

Further Notes

Apparently not all browser are correctly disabling links. Therefore, some users managed to call the edit_lane function. It might be more appropriate to hide these links instead of disabling them.

@JannikStreek JannikStreek self-assigned this Oct 18, 2024
@JannikStreek JannikStreek changed the title Bug: crash with missing permissions when editing a lane Bug: Some browser show disabled links Oct 22, 2024
@PragTob
Copy link
Collaborator

PragTob commented Nov 3, 2024

Not 100% sure what the response was/what happened but maybe we should also make the response if someone manages to use it better. Never trust the frontend :)

@JannikStreek
Copy link
Member Author

Not 100% sure what the response was/what happened but maybe we should also make the response if someone manages to use it better. Never trust the frontend :)

we do not trust the frontend, the authorization checks are also included inside the live components / live views (so we are not showing the link AND making sure the logic does not work when triggered). Still, the links should not work / be visible, but this seems to be the case for some browsers that do not disable the links. Therefore, not showing them at all might be the better options here.

@JannikStreek JannikStreek added the type-bug Something isn't working label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants