Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump nwsapi to avoid global pollution? #151

Open
cscheid opened this issue Nov 14, 2023 · 1 comment
Open

bump nwsapi to avoid global pollution? #151

cscheid opened this issue Nov 14, 2023 · 1 comment

Comments

@cscheid
Copy link

cscheid commented Nov 14, 2023

While linting the bundled releases of quarto, we've noticed that deno-dom pollutes the global scope. We narrowed it down to nwsapi.js:367, etc.

The upstream nwsapi library has fixes for these. Would updating nwsapi be considered a bug in scope in deno-dom?

@b-fuze
Copy link
Owner

b-fuze commented Nov 16, 2023

Yes, we can do this. I've actually already prepared this, but put it off because of some fixes that the NWSApi developer said were resolved were not actually resolved when I tested them locally.

But if it pollutes the global namespace less then I'm all for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants