Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Holiday in German Provider - New Year’s Eve (31/12) #354

Open
iamxnuel opened this issue Jan 7, 2025 · 1 comment
Open

Incorrect Holiday in German Provider - New Year’s Eve (31/12) #354

iamxnuel opened this issue Jan 7, 2025 · 1 comment
Labels

Comments

@iamxnuel
Copy link

iamxnuel commented Jan 7, 2025

31/12, New Year’s Eve, is not a public holiday in any German state. However, it appears to have been incorrectly added as a holiday in the German provider and on your documentation: https://www.yasumi.dev/docs/providers/de/.

See https://en.wikipedia.org/wiki/Public_holidays_in_Germany

Could you please verify and correct this issue? Thank you!

@stelgenhof
Copy link
Member

@iamxnuel The documentation site shows all holidays that are registered of a provider, irrespective of whether it is a public/official holiday or not. New Year's Eve for Germany is correctly registered as a non-official holiday in Yasumi, see:
https://github.com/azuyalabs/yasumi/blob/develop/src/Yasumi/Provider/Germany.php#L50

I realize the documentation site is not really clear on that, so I will work on the documentation site to make that more explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants