How to apply clang-tidy auto-fix (e.g. modernize-* checks)

[FrancescoBorzi]

clang-tidy is

a clang-based C++ “linter” tool. Its purpose is to provide an extensible framework for diagnosing and fixing typical programming errors, like style violations, interface misuse, or bugs that can be deduced via static analysis.

Among all its available checks, there is a collection of modernize-* checks that offer automated fixes. It would be nice to apply them to our codebase in order to make it more "modern" and resolve potential issues and warnings.

This way it is possible to run clang-tidy and automatically fix the whole codebase.

After this is done, it would be nice to add an automated check to our CI to prevent new issues to get to master, this is part of #2745

Current progress:

• modernize-avoid-bind (no issues found as of 66e65c4)
• modernize-concat-nested-namespaces (no issues found as of 66e65c4)
• modernize-deprecated-headers (refactor(Core): apply clang-tidy modernize-deprecated-headers #3821)
• modernize-deprecated-ios-base-aliases (no issues found as of 66e65c4)
• modernize-loop-convert (refactor(Core): apply clang-tidy modernize-loop-convert #3822)
• modernize-make-shared (no issues found as of 66e65c4)
• modernize-make-unique (no issues found as of 66e65c4)
• modernize-pass-by-value (refactor(Core): apply clang-tidy modernize-pass-by-value #3823)
• modernize-raw-string-literal (refactor(Core): apply clang-tidy modernize-raw-string-literal #3824)
• modernize-redundant-void-arg (refactor(Core): apply clang-tidy modernize-redundant-void-arg #3825)
• modernize-replace-auto-ptr (no issues found as of 0baecd3)
• modernize-replace-disallow-copy-and-assign-macro (no issues found as of 0baecd3)
• modernize-replace-random-shuffle (no issues found as of 0baecd3)
• modernize-return-braced-init-list (no issues found as of 0baecd3)
• modernize-shrink-to-fit (no issues found as of 0baecd3)
• modernize-unary-static-assert (no issues found as of 0baecd3)
• modernize-use-auto (this is probably going to be very big, so better do it after the others are merged)
• modernize-use-bool-literals (refactor(Core): apply clang-tidy modernize-use-bool-literals #3826)
• modernize-use-default-member-init (refactor(Core): apply clang-tidy modernize-use-default-member-init #3827)
• modernize-use-emplace (refactor(Core): apply clang-tidy modernize-use-emplace #3828)
• modernize-use-equals-default (refactor(Core): apply clang-tidy modernize-use-equals-default #3834)
• modernize-use-equals-delete (no issues found as of 221f33b)
• modernize-use-nodiscard (refactor(Core): apply clang-tidy modernize-use-nodiscard #3835)
• modernize-use-noexcept (refactor(Core): apply clang-tidy modernize-use-noexcept #3837)
• modernize-use-nullptr (refactor(Core): apply clang-tidy modernize-use-nullptr #3819)
• modernize-use-override (refactor(Core): apply clang-tidy modernize-use-override #3817)
• modernize-use-trailing-return-type (no issues found as of 221f33b)
• modernize-use-transparent-functors (no issues found as of 221f33b)
• modernize-use-uncaught-exceptions (no issues found as of 221f33b)
• modernize-use-using (no issues found as of 221f33b)

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[FrancescoBorzi]

@azerothcore/developers @azerothcore/testers I'm finally done with this. I need reviewers/testers for all the linked PRs, which you can find here:

https://github.com/azerothcore/azerothcore-wotlk/pulls?q=is%3Apr+is%3Aopen+refactor%28Core%29%3A+apply+clang-tidy+modernize

[Kitzunu]

@FrancescoBorzi Status on modernize-use-auto

[FrancescoBorzi]

@FrancescoBorzi Status on modernize-use-auto

that's the only one missing here

[FrancescoBorzi]

converted to Discussion as the initial work has been completed but this is still a good reference

[FrancescoBorzi]

How-to

Requirement: install clang-tidy (for macOS see https://stackoverflow.com/questions/53111082/how-to-install-clang-tidy-on-macos)

1. Run cmake with: -DCMAKE_EXPORT_COMPILE_COMMANDS=ON it will generate a compile_commands.json file inside the build folder

2. Download this and place it inside the build folder (where compile_commands.json is located)

3. Run the following:

 ./run-clang-tidy.py -header-filter='.*' -checks='-*,modernize-concat-nested-namespaces' -fix;
 ./run-clang-tidy.py -header-filter='.*' -checks='-*,modernize-deprecated-headers' -fix;
 ./run-clang-tidy.py -header-filter='.*' -checks='-*,modernize-deprecated-ios-base-aliases' -fix;
 ./run-clang-tidy.py -header-filter='.*' -checks='-*,modernize-loop-convert' -fix;
 ./run-clang-tidy.py -header-filter='.*' -checks='-*,modernize-make-shared' -fix;
 ./run-clang-tidy.py -header-filter='.*' -checks='-*,modernize-make-unique' -fix;
 ./run-clang-tidy.py -header-filter='.*' -checks='-*,modernize-pass-by-value' -fix;
 ./run-clang-tidy.py -header-filter='.*' -checks='-*,modernize-raw-string-literal' -fix;
 ./run-clang-tidy.py -header-filter='.*' -checks='-*,modernize-redundant-void-arg' -fix;
 ./run-clang-tidy.py -header-filter='.*' -checks='-*,modernize-replace-auto-ptr' -fix;
 ./run-clang-tidy.py -header-filter='.*' -checks='-*,modernize-replace-disallow-copy-and-assign-macro' -fix;
 ./run-clang-tidy.py -header-filter='.*' -checks='-*,modernize-replace-random-shuffle' -fix;
 ./run-clang-tidy.py -header-filter='.*' -checks='-*,modernize-return-braced-init-list' -fix;
 ./run-clang-tidy.py -header-filter='.*' -checks='-*,modernize-shrink-to-fit' -fix;
 ./run-clang-tidy.py -header-filter='.*' -checks='-*,modernize-unary-static-assert' -fix;
 ./run-clang-tidy.py -header-filter='.*' -checks='-*,modernize-use-bool-literals' -fix;
 ./run-clang-tidy.py -header-filter='.*' -checks='-*,modernize-use-default-member-init' -fix;
 ./run-clang-tidy.py -header-filter='.*' -checks='-*,modernize-use-emplace' -fix;
 ./run-clang-tidy.py -header-filter='.*' -checks='-*,modernize-use-equals-default' -fix;
 ./run-clang-tidy.py -header-filter='.*' -checks='-*,modernize-use-equals-delete' -fix;
 ./run-clang-tidy.py -header-filter='.*' -checks='-*,modernize-use-nodiscard' -fix;
 ./run-clang-tidy.py -header-filter='.*' -checks='-*,modernize-use-noexcept' -fix;
 ./run-clang-tidy.py -header-filter='.*' -checks='-*,modernize-use-nullptr' -fix;
 ./run-clang-tidy.py -header-filter='.*' -checks='-*,modernize-use-override' -fix;
 ./run-clang-tidy.py -header-filter='.*' -checks='-*,modernize-use-trailing-return-type' -fix;
 ./run-clang-tidy.py -header-filter='.*' -checks='-*,modernize-use-transparent-functors' -fix;
 ./run-clang-tidy.py -header-filter='.*' -checks='-*,modernize-use-uncaught-exceptions' -fix;
 ./run-clang-tidy.py -header-filter='.*' -checks='-*,modernize-use-using' -fix;