Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combat Overlay implementation #6

Open
aymeric-giraudet opened this issue Nov 25, 2020 · 1 comment
Open

Combat Overlay implementation #6

aymeric-giraudet opened this issue Nov 25, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@aymeric-giraudet
Copy link
Owner

aymeric-giraudet commented Nov 25, 2020

Replicate what's done on the original overlay app
I think creating a new Electron window with a different html file from the main window would be better as it would allow users to place the combat overlay wherever they want and it doesn't share any state with the rest of the app so that's alright

@aymeric-giraudet aymeric-giraudet added the enhancement New feature or request label Nov 25, 2020
@aymeric-giraudet
Copy link
Owner Author

After some thinking, I've decided that maybe refactoring dialogManager further is not that important as it won't need too much maintenance anymore.
Priority should definitely be on the combat overlay ! So I've started working on it, style and ergonomics need some polishing and I still need to implement the filters.
After that it should be a breeze I think.

Pinging you @mikerollins to let you know :)

aymeric-giraudet added a commit that referenced this issue Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant