Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate in main ADS? #1

Open
mathieuboudreau opened this issue Oct 20, 2023 · 1 comment
Open

Integrate in main ADS? #1

mathieuboudreau opened this issue Oct 20, 2023 · 1 comment

Comments

@mathieuboudreau
Copy link
Member

Is there a reason why this need to be a completely separate repo, and not added as a feature (along with all the other ADS features) in our main software?

@hermancollin
Copy link
Member

@mathieuboudreau No particular reason honestly. I mentioned integrating nnUNet in ADS in the meetings but I guess I never created issues on the ADS repo. The endgoal is obviously to integrate these models in ADS but I feared it would take more time to merge into the main branch, and having a separate repo is simpler for the researchers for the moment.

Moreover, nnunet is a pretty big dependency. Considering ADS installation is already a bit long, I was not sure how we could deal with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants