Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback from IMP-1 #81

Open
npty opened this issue Feb 3, 2023 · 0 comments
Open

Feedback from IMP-1 #81

npty opened this issue Feb 3, 2023 · 0 comments

Comments

@npty
Copy link
Member

npty commented Feb 3, 2023

Since the #76 PR is quite big, I think it is more appropriate to address them later to make it easier to review.

@StephenFluin

I have some minor comments and more improvements for later, but this PR can be merged as is. Looks great!

why don't we have a shared sleep method? (we seem to redefine it in many places
why did you refactor to use arrow functions?
Some typos in untouched code I'll fix once this PR lands
(later) Looks like a bunch of format / whitespace changes, can you make sure the whitespace settings are in prettier in our global package.json (or appropriate prettier config file) so we all autoformat the same?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant