Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nodejs example to ES7 and Node v8.10 runtime #24

Open
jonrhall opened this issue Jan 14, 2019 · 3 comments
Open

Update nodejs example to ES7 and Node v8.10 runtime #24

jonrhall opened this issue Jan 14, 2019 · 3 comments

Comments

@jonrhall
Copy link

jonrhall commented Jan 14, 2019

Hi there, I'm a fellow Amazon developer, I'm wondering if you're open to pull requests to update the nodejs example to modern JavaScript? I just spent a few hours completing a ES7 rewrite of the module that's supported in the Node.js v8.10 runtime. I feel like it may better lay out some of the core concepts this example library is trying to convey, and update some of the functional foundations around syntax like let and const as well as arrow functions and other JS features that ES7 and AWS Lambda now support.

If you are, just let me know and I'll put a PR up. Cheers

@aro1976
Copy link

aro1976 commented Jan 14, 2019

I'm very interested in this, would you share your repo to take a look?

@jonrhall
Copy link
Author

Here's a gist of the changes:
https://gist.github.com/jonrhall/a8a79a39753195f4e2c35d13d777d71d

@feinstein
Copy link

@jonrhall if you find any bugs on your code in the future, please share it in here so we can fix it as well, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants