From 97b8b609a047525e449c858b562b90498dd847c9 Mon Sep 17 00:00:00 2001 From: Niyati Maheshwari Date: Tue, 12 Sep 2023 13:22:39 -0700 Subject: [PATCH 01/18] upload to codecov and add a badge --- .github/workflows/ci.yml | 6 +++++- README.md | 4 +++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 660e472b..44f703f6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -18,7 +18,7 @@ jobs: contents: read strategy: matrix: - os: [ macos-10.15, ubuntu-18.04, windows-2019] + os: [ macos-latest, ubuntu-latest, windows-2019] java: [ 8, 11, 16 ] steps: - name: Checkout the repository @@ -50,3 +50,7 @@ jobs: exit 1 fi shell: bash + - name: Codecov + uses: codecov/codecov-action@v3 + env: + CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} \ No newline at end of file diff --git a/README.md b/README.md index 919f4aef..61d75e1c 100644 --- a/README.md +++ b/README.md @@ -1,5 +1,7 @@ ## Amazon Kinesis Video Streams Producer SDK Java - +

+ +

## License This library is licensed under the Apache License, 2.0. From d05ba5480a8d56338590e279dcd99407c6920255 Mon Sep 17 00:00:00 2001 From: Niyati Maheshwari Date: Wed, 6 Dec 2023 14:56:46 -0800 Subject: [PATCH 02/18] upload coverage report --- .github/workflows/ci.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 44f703f6..f73aba44 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -50,7 +50,9 @@ jobs: exit 1 fi shell: bash - - name: Codecov + - name: Install Codecov uses: codecov/codecov-action@v3 env: - CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} \ No newline at end of file + CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} + - name: Upload coverage to Codecov + run: bash <(curl -s https://codecov.io/bash) \ No newline at end of file From aa14b6cbe41d03b19fb28d37e5a39ea9c7438286 Mon Sep 17 00:00:00 2001 From: Niyati Maheshwari Date: Wed, 6 Dec 2023 15:14:03 -0800 Subject: [PATCH 03/18] add codecov --- .github/workflows/ci.yml | 38 +++++++++++++++++++++++++++++++++----- pom.xml | 33 +++++++++++++++++++++++++-------- 2 files changed, 58 insertions(+), 13 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f73aba44..36775509 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -50,9 +50,37 @@ jobs: exit 1 fi shell: bash - - name: Install Codecov - uses: codecov/codecov-action@v3 - env: - CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} + codecov-build: + runs-on: ${{ matrix.os }} + permissions: + id-token: write + contents: read + strategy: + matrix: + os: [ ubuntu-latest] + java: [ 16 ] + steps: + - name: Checkout the repository + uses: actions/checkout@v2 + - name: Configure AWS Credentials + uses: aws-actions/configure-aws-credentials@v1 + with: + role-to-assume: ${{ secrets.AWS_ROLE_TO_ASSUME }} + role-session-name: ${{ secrets.AWS_ROLE_SESSION_NAME }} + aws-region: ${{ secrets.AWS_REGION }} + - name: Set up JDK + uses: actions/setup-java@v2 + with: + java-version: ${{ matrix.java }} + distribution: 'adopt' + cache: maven + - name: Build with Maven + run: mvn clean compile assembly:single + - name: Run tests + run: | + mvn clean test -DargLine="-Daws.accessKeyId=${AWS_ACCESS_KEY_ID} -Daws.secretKey=${AWS_SECRET_ACCESS_KEY} -Daws.sessionToken=${AWS_SESSION_TOKEN} -Djava.library.path=src/main/resources/lib/ubuntu/ -Dlog4j.configurationFile=log4j2.xml" + shell: bash - name: Upload coverage to Codecov - run: bash <(curl -s https://codecov.io/bash) \ No newline at end of file + uses: codecov/codecov-action@v4-beta + env: + CODECOV_TOKEN: ${{ secrets.CODECOV_ORG_TOKEN }} diff --git a/pom.xml b/pom.xml index e4b89894..b07eca8e 100644 --- a/pom.xml +++ b/pom.xml @@ -153,7 +153,12 @@ log4j-api 2.17.1 - + + junit + junit + 4.13.2 + test + @@ -212,13 +217,25 @@ - org.apache.maven.plugins - maven-surefire-plugin - 3.0.0-M5 - - - - + org.jacoco + jacoco-maven-plugin + 0.8.11 + + + prepare-agent + + prepare-agent + + + + report + test + + report + + + + From 701e8505123526ecaadb557699a013fa7cfc3fcc Mon Sep 17 00:00:00 2001 From: Niyati Maheshwari Date: Wed, 6 Dec 2023 15:19:08 -0800 Subject: [PATCH 04/18] update names --- .github/workflows/ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 36775509..84acc765 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -80,7 +80,7 @@ jobs: run: | mvn clean test -DargLine="-Daws.accessKeyId=${AWS_ACCESS_KEY_ID} -Daws.secretKey=${AWS_SECRET_ACCESS_KEY} -Daws.sessionToken=${AWS_SESSION_TOKEN} -Djava.library.path=src/main/resources/lib/ubuntu/ -Dlog4j.configurationFile=log4j2.xml" shell: bash - - name: Upload coverage to Codecov - uses: codecov/codecov-action@v4-beta + - name: Upload coverage reports to Codecov + uses: codecov/codecov-action@v3 env: - CODECOV_TOKEN: ${{ secrets.CODECOV_ORG_TOKEN }} + CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} From 420742399f2180301bb6421b5990877b821b8a05 Mon Sep 17 00:00:00 2001 From: Niyati Maheshwari Date: Wed, 6 Dec 2023 15:24:13 -0800 Subject: [PATCH 05/18] fix readme --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 61d75e1c..35dd3df1 100644 --- a/README.md +++ b/README.md @@ -2,6 +2,7 @@

+ ## License This library is licensed under the Apache License, 2.0. From 209d124d3df9c41ac43fd02a3fa3844e1e2835e4 Mon Sep 17 00:00:00 2001 From: Niyati Maheshwari Date: Wed, 6 Dec 2023 15:41:31 -0800 Subject: [PATCH 06/18] fix codecov build by removing matric --- .github/workflows/ci.yml | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 84acc765..a6a96122 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -51,29 +51,25 @@ jobs: fi shell: bash codecov-build: - runs-on: ${{ matrix.os }} + runs-on: ubuntu-latest permissions: id-token: write contents: read - strategy: - matrix: - os: [ ubuntu-latest] - java: [ 16 ] steps: - name: Checkout the repository - uses: actions/checkout@v2 + uses: actions/checkout@v4 + - name: Set up JDK 18 + uses: actions/setup-java@v2 + with: + java-version: 18 + distribution: 'adopt' + cache: maven - name: Configure AWS Credentials uses: aws-actions/configure-aws-credentials@v1 with: role-to-assume: ${{ secrets.AWS_ROLE_TO_ASSUME }} role-session-name: ${{ secrets.AWS_ROLE_SESSION_NAME }} aws-region: ${{ secrets.AWS_REGION }} - - name: Set up JDK - uses: actions/setup-java@v2 - with: - java-version: ${{ matrix.java }} - distribution: 'adopt' - cache: maven - name: Build with Maven run: mvn clean compile assembly:single - name: Run tests From 67395e5b22a172c68c5fa7acaab7cfbf3830f011 Mon Sep 17 00:00:00 2001 From: Niyati Maheshwari Date: Wed, 6 Dec 2023 16:25:18 -0800 Subject: [PATCH 07/18] specify file and directory both --- .github/workflows/ci.yml | 13 ++++++++----- pom.xml | 40 +++++++++++++++++++++------------------- 2 files changed, 29 insertions(+), 24 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a6a96122..979dc6e8 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -22,7 +22,7 @@ jobs: java: [ 8, 11, 16 ] steps: - name: Checkout the repository - uses: actions/checkout@v2 + uses: actions/checkout@v4 - name: Configure AWS Credentials uses: aws-actions/configure-aws-credentials@v1 with: @@ -30,7 +30,7 @@ jobs: role-session-name: ${{ secrets.AWS_ROLE_SESSION_NAME }} aws-region: ${{ secrets.AWS_REGION }} - name: Set up JDK - uses: actions/setup-java@v2 + uses: actions/setup-java@v4 with: java-version: ${{ matrix.java }} distribution: 'adopt' @@ -59,7 +59,7 @@ jobs: - name: Checkout the repository uses: actions/checkout@v4 - name: Set up JDK 18 - uses: actions/setup-java@v2 + uses: actions/setup-java@v4 with: java-version: 18 distribution: 'adopt' @@ -78,5 +78,8 @@ jobs: shell: bash - name: Upload coverage reports to Codecov uses: codecov/codecov-action@v3 - env: - CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} + with: + token: ${{ secrets.CODECOV_TOKEN }} + directory: target/surefire-reports/ + files: target/site/jacoco/jacoco.xml + diff --git a/pom.xml b/pom.xml index b07eca8e..db9fb647 100644 --- a/pom.xml +++ b/pom.xml @@ -217,25 +217,27 @@ - org.jacoco - jacoco-maven-plugin - 0.8.11 - - - prepare-agent - - prepare-agent - - - - report - test - - report - - - - + org.jacoco + jacoco-maven-plugin + 0.8.7 + + ${project.build.directory}/site/jacoco/jacoco.xml + + + + + prepare-agent + + + + report + verify + + report + + + + From 0bbd9a36e2884a00c783440a3b91ef40ab306528 Mon Sep 17 00:00:00 2001 From: Niyati Maheshwari Date: Wed, 6 Dec 2023 16:38:54 -0800 Subject: [PATCH 08/18] fix codecov --- .github/workflows/ci.yml | 81 ++++++++++++++++++++-------------------- 1 file changed, 41 insertions(+), 40 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 979dc6e8..47dc482e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -11,45 +11,45 @@ on: - master jobs: - build: - runs-on: ${{ matrix.os }} - permissions: - id-token: write - contents: read - strategy: - matrix: - os: [ macos-latest, ubuntu-latest, windows-2019] - java: [ 8, 11, 16 ] - steps: - - name: Checkout the repository - uses: actions/checkout@v4 - - name: Configure AWS Credentials - uses: aws-actions/configure-aws-credentials@v1 - with: - role-to-assume: ${{ secrets.AWS_ROLE_TO_ASSUME }} - role-session-name: ${{ secrets.AWS_ROLE_SESSION_NAME }} - aws-region: ${{ secrets.AWS_REGION }} - - name: Set up JDK - uses: actions/setup-java@v4 - with: - java-version: ${{ matrix.java }} - distribution: 'adopt' - cache: maven - - name: Build with Maven - run: mvn clean compile assembly:single - - name: Run tests - run: | - if [ "$RUNNER_OS" == "Linux" ]; then - mvn clean test -DargLine="-Daws.accessKeyId=${AWS_ACCESS_KEY_ID} -Daws.secretKey=${AWS_SECRET_ACCESS_KEY} -Daws.sessionToken=${AWS_SESSION_TOKEN} -Djava.library.path=src/main/resources/lib/ubuntu/ -Dlog4j.configurationFile=log4j2.xml" - elif [ "$RUNNER_OS" == "Windows" ]; then - mvn clean test -DargLine="-Daws.accessKeyId=${AWS_ACCESS_KEY_ID} -Daws.secretKey=${AWS_SECRET_ACCESS_KEY} -Daws.sessionToken=${AWS_SESSION_TOKEN} -Djava.library.path=src/main/resources/lib/windows/ -Dlog4j.configurationFile=log4j2.xml" - elif [ "$RUNNER_OS" == "macOS" ]; then - mvn clean test -DargLine="-Daws.accessKeyId=${AWS_ACCESS_KEY_ID} -Daws.secretKey=${AWS_SECRET_ACCESS_KEY} -Daws.sessionToken=${AWS_SESSION_TOKEN} -Djava.library.path=src/main/resources/lib/mac/ -Dlog4j.configurationFile=log4j2.xml" - else - echo "$RUNNER_OS not supported" - exit 1 - fi - shell: bash + # build: + # runs-on: ${{ matrix.os }} + # permissions: + # id-token: write + # contents: read + # strategy: + # matrix: + # os: [ macos-latest, ubuntu-latest, windows-2019] + # java: [ 8, 11, 16 ] + # steps: + # - name: Checkout the repository + # uses: actions/checkout@v4 + # - name: Configure AWS Credentials + # uses: aws-actions/configure-aws-credentials@v1 + # with: + # role-to-assume: ${{ secrets.AWS_ROLE_TO_ASSUME }} + # role-session-name: ${{ secrets.AWS_ROLE_SESSION_NAME }} + # aws-region: ${{ secrets.AWS_REGION }} + # - name: Set up JDK + # uses: actions/setup-java@v4 + # with: + # java-version: ${{ matrix.java }} + # distribution: 'adopt' + # cache: maven + # - name: Build with Maven + # run: mvn clean compile assembly:single + # - name: Run tests + # run: | + # if [ "$RUNNER_OS" == "Linux" ]; then + # mvn clean test -DargLine="-Daws.accessKeyId=${AWS_ACCESS_KEY_ID} -Daws.secretKey=${AWS_SECRET_ACCESS_KEY} -Daws.sessionToken=${AWS_SESSION_TOKEN} -Djava.library.path=src/main/resources/lib/ubuntu/ -Dlog4j.configurationFile=log4j2.xml" + # elif [ "$RUNNER_OS" == "Windows" ]; then + # mvn clean test -DargLine="-Daws.accessKeyId=${AWS_ACCESS_KEY_ID} -Daws.secretKey=${AWS_SECRET_ACCESS_KEY} -Daws.sessionToken=${AWS_SESSION_TOKEN} -Djava.library.path=src/main/resources/lib/windows/ -Dlog4j.configurationFile=log4j2.xml" + # elif [ "$RUNNER_OS" == "macOS" ]; then + # mvn clean test -DargLine="-Daws.accessKeyId=${AWS_ACCESS_KEY_ID} -Daws.secretKey=${AWS_SECRET_ACCESS_KEY} -Daws.sessionToken=${AWS_SESSION_TOKEN} -Djava.library.path=src/main/resources/lib/mac/ -Dlog4j.configurationFile=log4j2.xml" + # else + # echo "$RUNNER_OS not supported" + # exit 1 + # fi + # shell: bash codecov-build: runs-on: ubuntu-latest permissions: @@ -65,7 +65,7 @@ jobs: distribution: 'adopt' cache: maven - name: Configure AWS Credentials - uses: aws-actions/configure-aws-credentials@v1 + uses: aws-actions/configure-aws-credentials@v4 with: role-to-assume: ${{ secrets.AWS_ROLE_TO_ASSUME }} role-session-name: ${{ secrets.AWS_ROLE_SESSION_NAME }} @@ -82,4 +82,5 @@ jobs: token: ${{ secrets.CODECOV_TOKEN }} directory: target/surefire-reports/ files: target/site/jacoco/jacoco.xml + fail_ci_if_error: true From 2c4937d1e78e2edad52f17cce843e8dc101cade9 Mon Sep 17 00:00:00 2001 From: Niyati Maheshwari Date: Wed, 6 Dec 2023 16:40:01 -0800 Subject: [PATCH 09/18] remove dup junit --- pom.xml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/pom.xml b/pom.xml index db9fb647..e07949d3 100644 --- a/pom.xml +++ b/pom.xml @@ -153,12 +153,6 @@ log4j-api 2.17.1 - - junit - junit - 4.13.2 - test - From 7b14be3065573c31bd9672fddd264a7c4a32d6f0 Mon Sep 17 00:00:00 2001 From: Niyati Maheshwari Date: Wed, 6 Dec 2023 16:54:46 -0800 Subject: [PATCH 10/18] check contents after run --- .github/workflows/ci.yml | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 47dc482e..dac10e11 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -76,11 +76,15 @@ jobs: run: | mvn clean test -DargLine="-Daws.accessKeyId=${AWS_ACCESS_KEY_ID} -Daws.secretKey=${AWS_SECRET_ACCESS_KEY} -Daws.sessionToken=${AWS_SESSION_TOKEN} -Djava.library.path=src/main/resources/lib/ubuntu/ -Dlog4j.configurationFile=log4j2.xml" shell: bash - - name: Upload coverage reports to Codecov - uses: codecov/codecov-action@v3 - with: - token: ${{ secrets.CODECOV_TOKEN }} - directory: target/surefire-reports/ - files: target/site/jacoco/jacoco.xml - fail_ci_if_error: true + - name: Check contents + run: | + sudo apt-get install tree + tree + # - name: Upload coverage reports to Codecov + # uses: codecov/codecov-action@v3 + # with: + # token: ${{ secrets.CODECOV_TOKEN }} + # directory: target/surefire-reports/ + # files: target/site/jacoco/jacoco.xml + # fail_ci_if_error: true From 31410992227a1c68936714eb1fb81005b007f0af Mon Sep 17 00:00:00 2001 From: Niyati Maheshwari Date: Wed, 6 Dec 2023 17:11:16 -0800 Subject: [PATCH 11/18] mvn clean verify --- .github/workflows/ci.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index dac10e11..f9e5994a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -74,17 +74,17 @@ jobs: run: mvn clean compile assembly:single - name: Run tests run: | - mvn clean test -DargLine="-Daws.accessKeyId=${AWS_ACCESS_KEY_ID} -Daws.secretKey=${AWS_SECRET_ACCESS_KEY} -Daws.sessionToken=${AWS_SESSION_TOKEN} -Djava.library.path=src/main/resources/lib/ubuntu/ -Dlog4j.configurationFile=log4j2.xml" + mvn clean verify -DargLine="-Daws.accessKeyId=${AWS_ACCESS_KEY_ID} -Daws.secretKey=${AWS_SECRET_ACCESS_KEY} -Daws.sessionToken=${AWS_SESSION_TOKEN} -Djava.library.path=src/main/resources/lib/ubuntu/ -Dlog4j.configurationFile=log4j2.xml" shell: bash - name: Check contents run: | sudo apt-get install tree tree - # - name: Upload coverage reports to Codecov - # uses: codecov/codecov-action@v3 - # with: - # token: ${{ secrets.CODECOV_TOKEN }} - # directory: target/surefire-reports/ - # files: target/site/jacoco/jacoco.xml - # fail_ci_if_error: true + - name: Upload coverage reports to Codecov + uses: codecov/codecov-action@v3 + with: + token: ${{ secrets.CODECOV_TOKEN }} + directory: target/surefire-reports/ + # files: target/site/jacoco/jacoco.xml + fail_ci_if_error: true From 385d2da01c5583e730b516e954b219a329424478 Mon Sep 17 00:00:00 2001 From: Niyati Maheshwari Date: Wed, 6 Dec 2023 18:00:26 -0800 Subject: [PATCH 12/18] try java 11 --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f9e5994a..84c00955 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -61,7 +61,7 @@ jobs: - name: Set up JDK 18 uses: actions/setup-java@v4 with: - java-version: 18 + java-version: 11 distribution: 'adopt' cache: maven - name: Configure AWS Credentials From aebe93805a520bf764eacc3f563a5c281f7dda1e Mon Sep 17 00:00:00 2001 From: Niyati Maheshwari Date: Wed, 6 Dec 2023 18:12:16 -0800 Subject: [PATCH 13/18] no cache --- .github/workflows/ci.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 84c00955..6ef1db95 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -62,8 +62,6 @@ jobs: uses: actions/setup-java@v4 with: java-version: 11 - distribution: 'adopt' - cache: maven - name: Configure AWS Credentials uses: aws-actions/configure-aws-credentials@v4 with: From ec94a1b3803f0c6d80e262751060c0aa3ca5cc2c Mon Sep 17 00:00:00 2001 From: Niyati Maheshwari Date: Wed, 6 Dec 2023 18:14:19 -0800 Subject: [PATCH 14/18] no cache --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6ef1db95..fd628027 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -62,6 +62,7 @@ jobs: uses: actions/setup-java@v4 with: java-version: 11 + distribution: 'adopt' - name: Configure AWS Credentials uses: aws-actions/configure-aws-credentials@v4 with: From 432acb6fed8ab7d5566c15e480d81ccae91bece5 Mon Sep 17 00:00:00 2001 From: Niyati Maheshwari Date: Wed, 6 Dec 2023 19:12:19 -0800 Subject: [PATCH 15/18] jacoco dependency --- .github/workflows/ci.yml | 4 ++-- pom.xml | 5 +++++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index fd628027..b0b605ff 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -83,7 +83,7 @@ jobs: uses: codecov/codecov-action@v3 with: token: ${{ secrets.CODECOV_TOKEN }} - directory: target/surefire-reports/ - # files: target/site/jacoco/jacoco.xml + # directory: target/surefire-reports/ + files: /home/runner/work/amazon-kinesis-video-streams-producer-sdk-java/amazon-kinesis-video-streams-producer-sdk-java/target/site/jacoco/jacoco.xml fail_ci_if_error: true diff --git a/pom.xml b/pom.xml index e07949d3..8161e7b1 100644 --- a/pom.xml +++ b/pom.xml @@ -153,6 +153,11 @@ log4j-api 2.17.1 + + org.jacoco + jacoco-maven-plugin + 0.8.5 + From 92e668d81311d38a16b4f7926f77e4296cea9ff4 Mon Sep 17 00:00:00 2001 From: Niyati Maheshwari Date: Wed, 6 Dec 2023 19:31:16 -0800 Subject: [PATCH 16/18] try mvn clean test instead of verify --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b0b605ff..dbea438a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -73,7 +73,7 @@ jobs: run: mvn clean compile assembly:single - name: Run tests run: | - mvn clean verify -DargLine="-Daws.accessKeyId=${AWS_ACCESS_KEY_ID} -Daws.secretKey=${AWS_SECRET_ACCESS_KEY} -Daws.sessionToken=${AWS_SESSION_TOKEN} -Djava.library.path=src/main/resources/lib/ubuntu/ -Dlog4j.configurationFile=log4j2.xml" + mvn clean test -DargLine="-Daws.accessKeyId=${AWS_ACCESS_KEY_ID} -Daws.secretKey=${AWS_SECRET_ACCESS_KEY} -Daws.sessionToken=${AWS_SESSION_TOKEN} -Djava.library.path=src/main/resources/lib/ubuntu/ -Dlog4j.configurationFile=log4j2.xml" shell: bash - name: Check contents run: | From b72370be83025b4190fa1ebb85774baffd1ceaaf Mon Sep 17 00:00:00 2001 From: Niyati Maheshwari Date: Wed, 6 Dec 2023 20:09:04 -0800 Subject: [PATCH 17/18] try using .8.11 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 8161e7b1..53a63a01 100644 --- a/pom.xml +++ b/pom.xml @@ -156,7 +156,7 @@ org.jacoco jacoco-maven-plugin - 0.8.5 + 0.8.11 @@ -218,7 +218,7 @@ org.jacoco jacoco-maven-plugin - 0.8.7 + 0.8.11 ${project.build.directory}/site/jacoco/jacoco.xml From dc1bbe9a63cd6b59968a4c4813d36132fb84d22b Mon Sep 17 00:00:00 2001 From: Niyati Maheshwari Date: Wed, 6 Dec 2023 20:20:07 -0800 Subject: [PATCH 18/18] try macos instead of ubuntu --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index dbea438a..408485d4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -51,14 +51,14 @@ jobs: # fi # shell: bash codecov-build: - runs-on: ubuntu-latest + runs-on: macos-latest permissions: id-token: write contents: read steps: - name: Checkout the repository uses: actions/checkout@v4 - - name: Set up JDK 18 + - name: Set up JDK 11 uses: actions/setup-java@v4 with: java-version: 11