Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

failing test: target=code: typescript #5587

Open
jpinkney-aws opened this issue Sep 13, 2024 · 2 comments
Open

failing test: target=code: typescript #5587

jpinkney-aws opened this issue Sep 13, 2024 · 2 comments
Labels
automation bug We can reproduce the issue and confirmed it is a bug. sam tests-ci-cd

Comments

@jpinkney-aws
Copy link
Contributor

Problem

The following test is failing in CI (and probably locally as well):

 SamDebugConfigurationProvider
       makeConfig
         target=code: typescript:
     Error: TypeScript compiler "tsc" not found in node_modules/ or the system.
      at compileTypeScript (src/shared/sam/debugger/typescriptSamDebug.ts:214:15)
      at async Object.makeTypescriptConfig (src/shared/sam/debugger/typescriptSamDebug.ts:77:5)
      at async SamDebugConfigProvider.makeConfig (src/shared/sam/debugger/awsSamDebugger.ts:635:32)
      at async Context.<anonymous> (src/test/shared/sam/debugger/samDebugConfigProvider.test.ts:706:29)

According to PR's it looks like it started failing yesterday
@jpinkney-aws jpinkney-aws added bug We can reproduce the issue and confirmed it is a bug. tests-ci-cd sam automation labels Sep 13, 2024
@jpinkney-aws
Copy link
Contributor Author

On recent PR's it looks like its recovered. I'm guessing there was a temporary outage with downloading typescript? Or something else weird going on?

If I don't see the problem again in a few days I'll close this

@jpinkney-aws
Copy link
Contributor Author

Nvm looks like I got it in https://github.com/aws/aws-toolkit-vscode/actions/runs/10854578001/job/30125976412

@justinmk3 justinmk3 mentioned this issue Sep 16, 2024
Merged
justinmk3 pushed a commit that referenced this issue Sep 16, 2024
@jpinkney-aws
ci: skip "target=code: typescript" test on mac ci #5600
0d3462a 
## Problem
- This test started failing around sept 10th with no clear code change
- #5587

## Solution
- Until we can figure out the problem lets just disable it on mac ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
automation bug We can reproduce the issue and confirmed it is a bug. sam tests-ci-cd
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jpinkney-aws