Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWSSDK.Extensions.CrtIntegration AssemblyFileVersion is not updated #3181

Closed
koimatcha opened this issue Feb 9, 2024 · 3 comments
Closed
Labels
bug This issue is a bug. Extensions low-effort p3 This is a minor priority issue queued

Comments

@koimatcha
Copy link

Describe the bug

Hi, the file version of 'AWSSDK.Extensions.CrtIntegration.dll' is still "Version 3.7.0.0". So the Installer does not update the previous version of this file at all. The "AssemblyFileVersion" should be "3.7.300.1".

"extensions/src/AWSSDK.Extensions.CrtIntegration/Properties/AssemblyInfo.cs"
[assembly: AssemblyFileVersion("3.7.0.0")] <= here

Expected Behavior

Any installer can replace the previous version of AWSSDK.Extensions.CrtIntegration.dll with the new one.

Current Behavior

The Installer does not replace the previous version of this file.

Reproduction Steps

Installing AWSSDK.Extensions.CrtIntegration.dll by creating any MSI installer.

Possible Solution

No response

Additional Information/Context

No response

AWS .NET SDK and/or Package version used

AWSSDK.Extensions.CrtIntegration 3.7.300.1

Targeted .NET Platform

.NET Framework 4.8.1

Operating System and version

Windows 11

@koimatcha koimatcha added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Feb 9, 2024
@bhoradc bhoradc self-assigned this Mar 1, 2024
@bhoradc bhoradc added Extensions p3 This is a minor priority issue needs-review low-effort and removed needs-triage This issue or PR still needs to be triaged. labels Mar 1, 2024
@bhoradc
Copy link

bhoradc commented Mar 1, 2024

Hi @koimatcha,

Thanks for bringing this issue to our notice. We will review this with our team and work on the fix accordingly.

Regards,
Chaitanya

@dscpinheiro
Copy link
Contributor

This has been fixed in the latest version of the AWSSDK.Extensions.CrtIntegration package: https://www.nuget.org/packages/AWSSDK.Extensions.CrtIntegration/3.7.300.3

Copy link

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. Extensions low-effort p3 This is a minor priority issue queued
Projects
None yet
Development

No branches or pull requests

3 participants