s390x: CRC32/checksum tests failing

[bolives-hax]

Describe the bug

sdk-aws-log.txt

While adding s390x (IBM system Z10-Z15 mainframe arch) support to NixOS, i encountered the following issue trying to build this package during the test phase: (see log)

I suspect endianess is to blame here but im not sure, disabling some tests like:

    rm tests/aws-cpp-sdk-core-tests/utils/memory/AWSMemoryTest.cpp
    rm tests/aws-cpp-sdk-core-tests/utils/event/EventStreamDecoderTest.cpp
    rm tests/aws-cpp-sdk-core-tests/utils/event/EventStreamTest.cpp
    rm tests/aws-cpp-sdk-core-tests/utils/HashingUtilsTest.cpp

makes the build complete without any errors/failures. Building the same package for other architectures works thus I suspect due to the nature of these issues its an endianess related problem.

I couldn't confirm if the lib works like intended on s390x but building my system against it seemed to not trigger any issues so its either not getting used or despite failing these tests works.

Regression Issue

• Select this option if this issue appears to be a regression.

Expected Behavior

I expected the tests not to fail like on other architectures

Current Behavior

various issues such as:

ESC[0;31m[  FAILED  ] ESC[mHashingUtilsTest.TestCRC32CFromStream (154 ms)
/build/source/tests/aws-cpp-sdk-core-tests/utils/HashingUtilsTest.cpp:406: Failure
Expected equality of these values:
  expectedHexHash
    Which is: "91267e8a"
  hexHash.c_str()
    Which is: "1c6a2029"
ESC[0;31m[  FAILED  ] ESC[mHashingUtilsTest.TestCRC32FromStream (156 ms)

taking place

Reproduction Steps

I assume that its highly unlikely someone will reproduce it as most likely im the only person on earth atm running NixOS on a mainframe as support only got recently added by me. But I will still share one of the releases I made a while ago that relies on these tests being disabled

https://github.com/bolives-hax/nixos-s390x-images/releases/tag/1.0.0

I think it may be easier to ask me for a s390x container that getting this to run in qemu(emul). If one still wants to give the emulator a try I'd suggest going with a distro that offers prebuild compilers/build packages for s390x

Possible Solution

No response

Additional Information/Context

No response

AWS CPP SDK version used

aws-sdk-cpp-1.11.336

Compiler and Version used

gcc GNU 13.3.0

Operating System and version

NixOS 24.11 / master

[DmitriyMusatkin]

this will be fixed once cpp sdk integrates this awslabs/aws-checksums@b23b2e2.
big endian is currently not supported

[jmklix]

The fixed was merged when the crt version was bumped in this PR. Please update to the latest version of this sdk

[github-actions]

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.