-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Directory.build.props heirarchy is not respected #211
Comments
In connection with AWS SAM this is even worse. If you set for example your directories for temporary and binary directories, or the language version on global level via |
This is something I've tackled in #183. |
Small note: we explored using the new Here's the commit for reference: aws/aws-lambda-dotnet@357bf99 |
Describe the bug
When packaging a lambda using
dotnet lambda package
, if the target project does not include a<TargetFramework>
node (because it is defined in a Directory.build.props at a higher location) the packaging tool fails saying it does not know what framework to use.Missing required parameter: --framework
Expected Behavior
The tool will understand that MSBuild can walk directories searching for Directory.build.props files to define these values.
Current Behavior
The tool fails to walk the folder heirarchy to find the values necessary for the build.
Reproduction Steps
Create a csproj file for a lambda without <TargetFramework>.
In a directory higher (say, next to your sln file) define a 'Directory.build.props' file and add a node there.
This behaviour is all defined here:
https://docs.microsoft.com/en-us/visualstudio/msbuild/customize-your-build?view=vs-2022
Possible Solution
No response
Additional Information/Context
No response
AWS .NET SDK and/or Package version used
dotnet lambda tools 5.3.0
Targeted .NET Platform
.Net 6
Operating System and version
Windows 10
The text was updated successfully, but these errors were encountered: