Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for parameter overrides in CFn templates #159

Open
NickDarvey opened this issue Feb 25, 2021 · 2 comments
Open

Support for parameter overrides in CFn templates #159

NickDarvey opened this issue Feb 25, 2021 · 2 comments
Labels
feature-request A feature should be added or improved. module/cli-ext p2 This is a standard priority issue queued

Comments

@NickDarvey
Copy link

I see that template parameters are supported via an argument:

var map = GetKeyValuePairOrDefault(this.TemplateParameters, LambdaDefinedCommandOptions.ARGUMENT_CLOUDFORMATION_TEMPLATE_PARAMETER, false);

However it would be great if you were also able to refer to a file, similar to the AWS CLI.

e.g. something like:

dotnet lambda deploy-serverless --template-parameters file://parameters.my-stack-prod.json

which is similar to:

aws cloudformation deploy --template stack.yaml --stack-name my-stack --parameter-overrides file://parameters.my-stack-prod.json
@NickDarvey NickDarvey added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 25, 2021
@ashishdhingra
Copy link
Contributor

Needs review with the team.

@ashishdhingra ashishdhingra added needs-review and removed needs-triage This issue or PR still needs to be triaged. labels Jan 20, 2022
@madmox
Copy link

madmox commented Jan 24, 2022

I find the current --template-parameters syntax to be quite a pain to use, since you have to escape both \ and " characters from each parameter key and value. I was happy to be able to use the file:// syntax with aws cloudformation deploy, only to find out dotnet lambda deploy-serverless does not support it.

It's a real shame, because it means we have to handle the stack settings differently depending on a lot of factors: the CLI we are going to use for the deployment (aws cloudformation or dotnet lambda), and the OS/shell we are deploying from (Linux bash for CI servers and Windows powershell for dev machines). It would be a lot simpler to be able to pass in the path of a JSON file for all cases.

@ashishdhingra ashishdhingra added the p2 This is a standard priority issue label Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. module/cli-ext p2 This is a standard priority issue queued
Projects
None yet
Development

No branches or pull requests

3 participants