Skip to content
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

Difficult to override defaults in shared AWS account #548

Open
mpatters72 opened this issue Aug 22, 2018 · 3 comments
Open

Difficult to override defaults in shared AWS account #548

mpatters72 opened this issue Aug 22, 2018 · 3 comments

Comments

@mpatters72
Copy link

mpatters72 commented Aug 22, 2018

During upcoming training session we have 10+ people using the same AWS account.
A few simple changes could avoid name collisions.

Cloudformation templates:

  • Instruct people to add their name at the end of the StackName e.g. from k8s-workshop to k8s-workshop-myname
  • Add a parameter called 'EKS_CLUSTER_NAME', and set default to k8s-workshop, use this as cloudformation output. Either Instruct people to change name in the cloudformation e.g k8s-workshop-mike or let them use default
  • Also consider making the kops s3 bucket creation optional if people are working with EKS.
  • Consider calling a nested stack to just go ahead and create the EKS cluster as an option.

lab-ide-build.sh

  • Set EKS_CLUSTER_NAME to output from cloudformation stack as an exported environment variable.
  • Also consider setting AWS_DEFAULT_REGION to match region of cloudformation stack.

./create-kubeconfig.sh

  • Either use $EKS_CLUSTER_NAME, pass cluster name as variable, or use override if provided our fall back to hard-coded default.
  • Possibly echo that information out.

Various other places

  • update doc to use $EKS_CLUSTER_NAME variable

Other feedback

  • better separation of kops vs non-kops.
  • Separate troubleshooting stuff that might be needed when things go wrong from normal steps followed that are expected to work, eg. setting AZs in create-the-master-nodes

Cc @Cloudymind

@dalbhanj
Copy link
Contributor

Hi @mpatters72

Thanks for feedback on the workshop. I am a little hesitant to propose using single account in a group setting. If we get into that territory, we get into customized delivery of workshop content which is totally up to the speakers/audience if they want to consume it that way. We want to keep this workshop consumption as simple as it can and focus on enabling individual tutorials which is the meat of this workshop. For ex, if customers want to learn how to use Prometheus, Istio/Envoy, Helm charts on top of k8s cluster on AWS, they should find most current information.

I like your suggestion on better separation between kops and non-kops (EKS), and other suggestions like updating env variables. Please send us a PR so we can review it

@brianhammons
Copy link
Contributor

@dalbhanj can you assign this to me? i'm working directly w/ @mpatters72 on these edits.

@dalbhanj
Copy link
Contributor

/assign @Cloudymind

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants