-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to trace SDXL VAE decoder with a different dimension #34
Comments
Hi @neo , thank you for raising the issue. We are aware of compilation issues with different input shapes and are working to fix them in an upcoming release. |
Not sure how related it is, but I also tried to do it with |
and while I have you, one semi-related question I had was that, I saw previous SD samples all have the step compiling also the text encoder, but not with this SDXL example – is it considered no longer needed anymore? or is it just not included because we haven't get there yet? |
Apologies for the late reply on your latest question - it was not included because we hadn't gotten there yet. That said, in an upcoming release, we'll be tracing it in our samples for improved performance. |
Thank you for the response! I chatted with one of the neuron team members earlier and got the suggestion to use neuron-optimum from HF which does tracing on every component and has been working quite well for us 😊 However it would still be great to see the samples doing it on a lower level so ppl can learn what's going on under the hood. |
Can I add that when making the sample for the SDXL text encoder, can we provide examples around doing Thanks! |
In
torch-neuronx/inference/hf_pretrained_sdxl_1024_inference.ipynb
, I tried to change[1, 4, 128, 128]
to[1, 4, 104, 152]
and it didn't work; more specifically I was able to trace theunet
andpost_quant_conv
with such shape but not with the decoder.Here's the error I got:
And the text print out before the error:
Lastly the log-neuron-cc.txt:
The text was updated successfully, but these errors were encountered: