Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Custom Source Database for External Library Use #1178

Open
fuwamocoanon opened this issue Sep 24, 2024 · 0 comments
Open

Suggestion: Custom Source Database for External Library Use #1178

fuwamocoanon opened this issue Sep 24, 2024 · 0 comments

Comments

@fuwamocoanon
Copy link

This feature would link with the External Library and allow a user to create a Source + Image for the source for use in the Library

In Site.java a source is given the follow format

[TITLE]([##], "[title short]", "[URL]", R.drawable.ic_site_[title short]);

TITLE - Format used for contentV2.json
title short - the "nickname" for the site (simply just the lowercase)
URL - Can be setup to be a dummy URL. Anything works here as long as TITLE is also in INVISIBLE_SITES
R.drawable.ic_site_[title short] - calls for the source's image

Allowing a user to input [TITLE] + an image for the drawable would secure long-term EoL use for the app.

Idea for integration

  • Have a dictionary for storing each [TITLE] + [IMAGE]
  • [TITLE] can be used for [title short] as well
  • URL can be anything. https://dummyurl.com for example
  • Have another dictionary for storing each [TITLE] that functions as INVISIBLE_SITES
  • Add these dictionaries to the import worker

This should ensure legacy features don't need full refactoring beyond checking these 2 new dictionaries on top of the existing ones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant