Feat/Add vector database #152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| const logger = createLogger('vector-database'); | ||
|
|
||
| export class VectorDB { |
There was a problem hiding this comment.
See my comment regarding classes above.
There was a problem hiding this comment.
I highly suggest to keep the DB in class-based approach.
Each db is stateful (connection, indices, indexes and etc), class-based is much cleaner and easier.
We will have multiple instances, and it's natrually telling me to go with class instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #151 and partially addresses #120.
I have implemented an in-memory vector database using the library we discussed earlier. The database is designed to support multiple independent instances rather than a single unified one. For example, memories have their own dedicated database, and documents are stored in a separate one. Test cases have been developed to ensure the functionality of the vector database.
Additionally, I have added a script with a CLI command to resurrect or download memories, starting from the latest state and tracing back to genesis.
In a future PR, we can work on integrating the vector database into the workflow to enhance its functionality.