Switch postgres tests to run in a matrix of versions #2195
Conversation
github-actions
bot
added
area/datastore
josephschorr
force-pushed
the
pg-test-matrix
branch
3 times, most recently
from
d33ee54 to
2d9d84a
Compare
There was a problem hiding this comment.
The changes look good to me; I added some comments.
No need to address this here, but after testing this branch locally, some tests are taking very long locally:
That also led me to discover that a bunch of tests are not running for testPostgresDatastoreWithoutCommitTimestamps, in particular those in this if statement, is that intentional or an oversight, seems to me like an oversight. It feels like testPostgresDatastoreWithoutCommitTimestamps has drifted from testPostgresDatastore
Now that tests run on their own machines, can we revert #2186?
This is intentional - these tests should not run if there is an "in progress" migration step |
josephschorr
force-pushed
the
pg-test-matrix
branch
from
2d9d84a to
cde4bf8
Compare
I suspect the answer is "no": the main source of flakiness appears to be the resources of the machines getting exhausted and I suspect running the tests in parallel again will result in more flakiness; we'll have to try it to be sure though |
josephschorr
force-pushed
the
pg-test-matrix
branch
from
cde4bf8 to
67613e5
Compare
vroldanbet
force-pushed
the
pg-test-matrix
branch
from
67613e5 to
7aea384
Compare
| datastore: ["crdb", "mysql", "spanner"] | ||
| steps: | ||
| - uses: "actions/checkout@v4" | ||
| if: | |
There was a problem hiding this comment.
I think you can put the if on the whole job?
No description provided.