Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxyplease does not appear to honor system bypass list #5

Open
vbisbest opened this issue May 5, 2021 · 1 comment
Open

proxyplease does not appear to honor system bypass list #5

vbisbest opened this issue May 5, 2021 · 1 comment

Comments

@vbisbest
Copy link

vbisbest commented May 5, 2021

Testing on OSX. Sample:

	a, _ := url.Parse("http://localhost/")
	b, _ := url.Parse("https://www.google.com")

	dialContext2 := proxyplease.NewDialContext(proxyplease.Proxy{TargetURL: a})
	dialContext3 := proxyplease.NewDialContext(proxyplease.Proxy{TargetURL: b})

Output

2021/05/05 11:57:39 proxyplease.proxy> No proxy provided. Attempting to infer from system.
2021/05/05 11:57:39 proxyplease.proxy> Inferred proxy from system: http://127.0.0.1:8080
2021/05/05 11:57:40 proxyplease.proxy> No proxy provided. Attempting to infer from system.
2021/05/05 11:57:40 proxyplease.proxy> Inferred proxy from system: http://127.0.0.1:8080

Proxy settings:
Screen Shot 2021-05-05 at 11 59 44 AM

Expected:
the dialContext for localhost should have been "direct"

@vbisbest
Copy link
Author

vbisbest commented May 5, 2021

It appears this was added to go-get-proxy in 2018:
rapid7/go-get-proxied#4

Repository owner deleted a comment from NoneTypez Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@vbisbest and others