Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding totalSupply #44

Open
rahulrumalla opened this issue Aug 9, 2022 · 1 comment
Open

Consider adding totalSupply #44

rahulrumalla opened this issue Aug 9, 2022 · 1 comment

Comments

@rahulrumalla
Copy link
Collaborator

During my research on coverage and support, I found that etherscan relies on this function in their “Token Tracker” page, the main view for Tokens. Without this it displays it as “0” which might be a bit misleading to the user. I think this falls within the mission to have maximal compatibility with erc721.
@TimDaub
Copy link
Member

TimDaub commented Aug 9, 2022

It also displays "0" for ERC721 tokens that don't implement the enumerable extension. But yeah, I'd be open to adding totalSupply to the EIP interface. Ur welcome to send a pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rahulrumalla @TimDaub