Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it a problem that testTakeEOA and testGiveEOA produce the same validation signature? #42

Open
TimDaub opened this issue Aug 4, 2022 · 2 comments
Open

Is it a problem that testTakeEOA and testGiveEOA produce the same validation signature? #42

TimDaub opened this issue Aug 4, 2022 · 2 comments
Labels
question Further information is requested

Comments

@TimDaub
Copy link
Member

TimDaub commented Aug 4, 2022 •
edited
Loading

see:
@TimDaub TimDaub added the question Further information is requested label Aug 4, 2022
@ra-phael
Copy link

Do you mean from a security perspective?
I see that they're the same because the roles are swapped so the active and passive addresses are the same in both tests.

I think that maybe it would be worth renaming the current test to testTakeFromEOA and add a testTakeToEOA.
Actually, should the tests cover all these scenarios for both give() and take()?

Active: EOA, Passive: EOA Active: EOA, Passive: Contract
Active: Contract, Passive: EOA Active: Contract, Passive: Contract

@TimDaub
Copy link
Member Author

TimDaub commented Sep 5, 2022

related: https://ethereum-magicians.org/t/eip-4973-account-bound-tokens/8825/124?u=timdaub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TimDaub @ra-phael