Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused num_images param in cifar10 example #73

Open
QB3 opened this issue Nov 13, 2023 · 1 comment · May be fixed by #84
Open

Unused num_images param in cifar10 example #73

QB3 opened this issue Nov 13, 2023 · 1 comment · May be fixed by #84
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@QB3
Copy link
Contributor

QB3 commented Nov 13, 2023

The parameter num_images is currently unused in the cifar10 example

flags.DEFINE_integer("num_images", 50000, help="the number of generated images for evaluation")

It would be great to have a generate_cifar10.py to generate a given number of images, as in the edm code https://github.com/NVlabs/edm

@josephdviviano josephdviviano self-assigned this Nov 14, 2023
@kilianFatras kilianFatras added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 14, 2023
@kilianFatras
Copy link
Collaborator

Hello,

Thank you for noticing this unused variable. This will be removed in a future PR.

Regarding the generate_cifar10.py, I agree it is a good idea. I will add it to the to-do list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants