Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cifar10 experiments #40

Merged
merged 11 commits into from
Aug 23, 2023
Merged

Conversation

kilianFatras
Copy link
Collaborator

@kilianFatras kilianFatras commented Aug 17, 2023

What does this PR do?

I am opening a PR to add CIFAR 10 experiments to the TorchCFM library. This PR makes a major refactoring of the example folder (that is now split between notebooks and cifar10)/ I would like to discuss what should be added/removed/changed. These new files are supposed to reproduce examples in [1].

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

[1] OT-CFM https://arxiv.org/abs/2302.00482

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@kilianFatras kilianFatras linked an issue Aug 17, 2023 that may be closed by this pull request
10 tasks
@kilianFatras kilianFatras added the enhancement New feature or request label Aug 17, 2023
@kilianFatras kilianFatras linked an issue Aug 17, 2023 that may be closed by this pull request
Copy link
Collaborator

@josephdviviano josephdviviano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! no comments really. notebook is quite clear

@kilianFatras kilianFatras marked this pull request as draft August 19, 2023 18:24
@kilianFatras kilianFatras removed the request for review from atong01 August 23, 2023 15:21
@kilianFatras kilianFatras marked this pull request as ready for review August 23, 2023 15:21
@kilianFatras kilianFatras merged commit 4bae7c2 into atong01:main Aug 23, 2023
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Road to 1.1 script to reproduce cifar expr in table 5
2 participants