Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] creating a standalone general model only repository or be part of e3nn. #2

Open
luwei0917 opened this issue Mar 4, 2023 · 2 comments

Comments

@luwei0917
Copy link

Thanks for the great work! This repository is great for those want to reproduce your results. But the equiformer architecture itself is probably more general and versatile that those dataset your tested on. The new "linear, layer norm, DTP and the whole equiformer" modules are probably useful for others wanting to build upon e3nn as well. It will be great if you could separate our the architecture or maybe make it part of the e3nn package.
After a brief check on your nets folder, it seems that the equiformer module is already mostly disentangled from the task specific modification. I guess with slightly more effort to completely separate out the task specific parts and create into a standalone repository or integrate into the e3nn package, this work could have bigger impact.

@luwei0917 luwei0917 changed the title [Suggestion] creating a standalone model only repository or be part of e3nn. [Suggestion] creating a standalone general model only repository or be part of e3nn. Mar 4, 2023
@mariogeiger
Copy link

To answer from the e3nn side, I would be happy to merge such a PR in e3nn

@yilunliao
Copy link
Member

Hi @luwei0917 .
Thanks or your suggestion.

Let me discuss this with Mario and Tess.
I am considering including an example of Equiformer in e3nn instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants