Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make and expose only one router implementation #80

Open
albertogasparin opened this issue Apr 14, 2021 · 0 comments
Open

Make and expose only one router implementation #80

albertogasparin opened this issue Apr 14, 2021 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@albertogasparin
Copy link
Collaborator

Current split between Router, MemoryRouter and UniversalRouter is causing issue are features are not supported across the board and we increase even more the chances of misalignment.

We should kill both UniversalRouter and MemoryRouter, exposing just one Router that simply accepts history and allows isGlobal to be set on both router and resources stores (fixing #76).
@albertogasparin albertogasparin added bug Something isn't working enhancement New feature or request labels Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@albertogasparin