From 20410934f1f091f64fb19a4875845975adf98a8e Mon Sep 17 00:00:00 2001 From: Italo Valcy Date: Fri, 20 Sep 2024 17:34:35 -0300 Subject: [PATCH 1/4] adding sanity check to avoid sending empty topology to SDX-LC when it is pulling for the topology --- main.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/main.py b/main.py index 8635f73..d567f9d 100644 --- a/main.py +++ b/main.py @@ -382,6 +382,8 @@ def post_topology_to_sdxlc(self, converted_topology): @rest("topology/2.0.0", methods=["GET"]) def get_sdx_topology_v2(self, _request: Request) -> JSONResponse: """return sdx topology v2""" + if not self._converted_topo.get("nodes"): + return JSONResponse(status_code=204) return JSONResponse(self._converted_topo) @rest("topology/2.0.0", methods=["POST"]) From 3f3d578b6e50c7af152078813b111966a9f201e7 Mon Sep 17 00:00:00 2001 From: Italo Valcy Date: Fri, 20 Sep 2024 17:38:18 -0300 Subject: [PATCH 2/4] adding sanity check to avoid sending empty topology to SDX-LC when it is pulling for the topology --- main.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/main.py b/main.py index d567f9d..b64f2ba 100644 --- a/main.py +++ b/main.py @@ -383,7 +383,7 @@ def post_topology_to_sdxlc(self, converted_topology): def get_sdx_topology_v2(self, _request: Request) -> JSONResponse: """return sdx topology v2""" if not self._converted_topo.get("nodes"): - return JSONResponse(status_code=204) + return None return JSONResponse(self._converted_topo) @rest("topology/2.0.0", methods=["POST"]) From a04cc9d972021342dd547b85264aab4d9206e2f1 Mon Sep 17 00:00:00 2001 From: Italo Valcy Date: Fri, 20 Sep 2024 17:44:55 -0300 Subject: [PATCH 3/4] return empty dict --- main.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/main.py b/main.py index b64f2ba..43a8d9f 100644 --- a/main.py +++ b/main.py @@ -383,7 +383,7 @@ def post_topology_to_sdxlc(self, converted_topology): def get_sdx_topology_v2(self, _request: Request) -> JSONResponse: """return sdx topology v2""" if not self._converted_topo.get("nodes"): - return None + return JSONResponse({}, status_code=204) return JSONResponse(self._converted_topo) @rest("topology/2.0.0", methods=["POST"]) From 2e13de7f309fbce612ab0e83eaa9e6af57b107f9 Mon Sep 17 00:00:00 2001 From: Italo Valcy Date: Fri, 20 Sep 2024 18:02:22 -0300 Subject: [PATCH 4/4] return empty dict and status code 200 --- main.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/main.py b/main.py index 43a8d9f..c576330 100644 --- a/main.py +++ b/main.py @@ -383,7 +383,7 @@ def post_topology_to_sdxlc(self, converted_topology): def get_sdx_topology_v2(self, _request: Request) -> JSONResponse: """return sdx topology v2""" if not self._converted_topo.get("nodes"): - return JSONResponse({}, status_code=204) + return JSONResponse({}, status_code=200) return JSONResponse(self._converted_topo) @rest("topology/2.0.0", methods=["POST"])