Skip to content
This repository has been archived by the owner on Feb 15, 2024. It is now read-only.

Review graceful shutdown process #64

Open
atc0005 opened this issue Jun 28, 2020 · 1 comment
Open

Review graceful shutdown process #64

atc0005 opened this issue Jun 28, 2020 · 1 comment
Assignees
@atc0005
Labels
question Further information is requested
Milestone
Future

Comments

@atc0005
Copy link
Owner

atc0005 commented Jun 28, 2020

Found this via Twitter (I think?):

https://rafallorenz.com/go/handle-signals-to-graceful-shutdown-http-server/

Creating this issue as I figured it was worth reviewing the codebase to make sure the current approach used matches up with the recommendations in the article.
@atc0005 atc0005 added the question Further information is requested label Jun 28, 2020
@atc0005 atc0005 added this to the Future milestone Jun 28, 2020
@atc0005 atc0005 self-assigned this Jun 28, 2020
@atc0005
Copy link
Owner Author

atc0005 commented Jul 18, 2020

Also worth looking at:

https://github.com/letsencrypt/pebble/blob/05f79ba495ab6a27cbbc32e20b44afac52eb9914/cmd/command.go#L46

The ideas here could really help with simplifying the current shutdown approach.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@atc0005 atc0005

Labels
question Further information is requested
Projects
None yet
Milestone
Future
Development

No branches or pull requests
1 participant
@atc0005