ci: publish AsyncAPI Studio Docker image with additional version tag #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgreinacher
requested review from
magicmatatjahu,
KhudaDad414,
Amzani,
Shurtu-gal and
asyncapi-bot-eve
as code owners
🦋 Changeset detectedLatest commit: 854e072 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
❌ Deploy Preview for studio-next failed.
|
❌ Deploy Preview for modest-rosalind-098b67 failed.
|
fgreinacher
commented
Oct 23, 2024
| @@ -17,10 +17,18 @@ jobs: | |||
| username: ${{ secrets.DOCKER_USERNAME }} | |||
| password: ${{ secrets.DOCKER_PASSWORD }} | |||
|
|
|||
| - name: Get current Studio version | |||
| id: get-studio-version | |||
| uses: martinbeentjes/[email protected] | |||
There was a problem hiding this comment.
fgreinacher
commented
Oct 23, 2024
Comment on lines
+32
to
+34
| asyncapi/studio:latest | ||
| asyncapi/studio:${{ steps.get-studio-version.outputs.current-version}} |
There was a problem hiding this comment.
Syntax as mentioned in https://github.com/docker/build-push-action?tab=readme-ov-file#inputs
✅ Deploy Preview for asyncapi-studio-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/ptal |
|
@Amzani @magicmatatjahu @KhudaDad414 @Shurtu-gal Please take a look at this PR. Thanks! 👋 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extends the Docker publishing workflow so that an additonal version tag is published to Docker Hub. This already happened before the migration from
semantic-releasetochangesets. I think it's desirable to bring it back because there are only super outdated versions on Docker Hub right now: https://hub.docker.com/r/asyncapi/studio/tags.Related issue(s)
Let me know if I should create one.
⚒️ with ❤️ by Siemens