Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor assumes the document is not version 3 when it has an error and renders Blocks visualiser #1142

Open
catosaurusrex2003 opened this issue Sep 27, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@catosaurusrex2003
Copy link
Contributor

Describe the bug

According to the application logic Blocks visualiser should NOT display in sidebar if document is version 3.
So when a person edits the document and an error is made. The editor identifies the current document as not version 3 and displays the items in sidebar even though the document i am editing is version 3.

How to Reproduce

create any v3 document in the editor.
this will be the sidebar 👇
image
now purposely add an error
image
notice how the Blocks visualiser gets added to the sidebar. Which should not happen because we are still editing a v3 document. We never changed the document version.

Expected behavior

It should remember the version of the previous correct document and retain it till the next correct document is created.

If this issue is legit and accepted. i am willing to work on this.

@catosaurusrex2003 catosaurusrex2003 added the bug Something isn't working label Sep 27, 2024
Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@catosaurusrex2003
Copy link
Contributor Author

Received approval from @Shurtu-gal to proceed. I am now starting to work on this issue.
cc: @Amzani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

1 participant