Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove $ref field from Channel Item Object in next breaking change version (3.0.0) #699

Closed
5 tasks done
char0n opened this issue Jan 25, 2022 · 9 comments
Closed
5 tasks done
Labels
💡 Proposal (RFC 1) RFC Stage 1 (See CONTRIBUTING.md)

Comments

@char0n
Copy link
Collaborator

char0n commented Jan 25, 2022

This is continuation of #607. Changes for AsyncAPI 2.3 has already been issued.

AsyncAPI 2.3

The aim here is to limit complexity and bring more flexibility.

  • Deprecate the use of $ref fixed field in Channel Item Object
  • Introduce new fixed field called channels in Components Object with type of Map[string, Channel Item Object]

AsyncAPI 3.0.0

The aim here is to have single referencing mechanism within AsyncAPI 3.x spec (reducing complexity) - Reference Object

  • Remove $ref from Channel Item Object fixed fields
  • Change Channels Object patterned field type to Reference Object | Channel Item Object
  • Components Object.channels field type will change to Map[string, Channel Item Object | Reference Object]
@char0n
Copy link
Collaborator Author

char0n commented May 4, 2022

PR has been issued for next-major-spec branch.

@github-actions
Copy link

github-actions bot commented Sep 2, 2022

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added stale and removed stale labels Sep 2, 2022
@jonaslagoni
Copy link
Member

jonaslagoni commented Sep 28, 2022

As I can see we can close this issue as it's completed both for version 2 and 3. Or are we waiting for some implementations?

cc @char0n @fmvilas @derberg @dalelane

@char0n
Copy link
Collaborator Author

char0n commented Sep 28, 2022

@jonaslagoni sure, fine with me.

@derberg
Copy link
Member

derberg commented Oct 10, 2022

I don't think we should close as long as 3.0 is not yet merged and released.
We should rather make sure it is linked in description of #759 with info that it will be solved after the merge

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Feb 8, 2023
@char0n
Copy link
Collaborator Author

char0n commented Feb 8, 2023

Be patient @github-actions ;]

@github-actions github-actions bot removed the stale label Feb 9, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jun 9, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 8, 2023
@char0n
Copy link
Collaborator Author

char0n commented Nov 10, 2023

Reopening due to #699 (comment)

@char0n char0n reopened this Nov 10, 2023
@github-actions github-actions bot removed the stale label Nov 11, 2023
@smoya smoya closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 Proposal (RFC 1) RFC Stage 1 (See CONTRIBUTING.md)
Projects
None yet
Development

No branches or pull requests

4 participants