Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add extensions support #506

Merged
merged 13 commits into from
Apr 18, 2024
Merged

feat: add extensions support #506

merged 13 commits into from
Apr 18, 2024

Conversation

sambhavgupta0705
Copy link
Member

This PR is part of asyncapi mentorship program
related issue: #280

The previous was targeted to next-major-spec branch
All the changes have been copied and migrated to master branch

@sambhavgupta0705
Copy link
Member Author

cc: @derberg @smoya

@sambhavgupta0705
Copy link
Member Author

@derberg the previous pr was targetting to next-spec-major and this is targetting master.
I just copied the changes directly in this and now there are some deletions in https://github.com/asyncapi/spec-json-schemas/pull/506/files#diff-6deb33116f8f13032612ff1f8a6305914860872230d74fa630e77e3a277be4a2 for which I would like to know what should I do.

  • should I only add extension related changes
  • or should let this file as it is

@derberg
Copy link
Member

derberg commented Mar 25, 2024

@sambhavgupta0705 sorry can you point to some example line of code and give more context, I'm not sure I follow

@derberg derberg changed the title feat: add extensions from extensions catalog to schema on master feat: add extensions support Apr 17, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

derberg
derberg approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and merging as it is a PR that I worked with @sambhavgupta0705 for quite some time already, #443 was just merged into a wring branch 😄

@derberg
Copy link
Member

derberg commented Apr 18, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit a0975d9 into asyncapi:master Apr 18, 2024
10 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 6.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@derberg derberg mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg derberg approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas fmvilas is a code owner

@dalelane dalelane Awaiting requested review from dalelane dalelane is a code owner

@smoya smoya Awaiting requested review from smoya smoya is a code owner

@char0n char0n Awaiting requested review from char0n char0n is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

@GreenRover GreenRover Awaiting requested review from GreenRover GreenRover is a code owner

@jonaslagoni jonaslagoni Awaiting requested review from jonaslagoni jonaslagoni is a code owner

@Pakisan Pakisan Awaiting requested review from Pakisan Pakisan is a code owner

Assignees
No one assigned
Labels
ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sambhavgupta0705 @derberg @asyncapi-bot