-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add migration guide #789
Conversation
Co-authored-by: Sergio Moya <[email protected]>
Co-authored-by: Sergio Moya <[email protected]>
Think I solved both your comments (including #789 (comment)) @smoya let me know if not 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀🌔
@smoya can you disable sonarcloud required check 🙂 |
Or merge it manually. |
I think I can't. The issue is with duplicated lines. TBH I don't really understand why the analysis is not limited to the changes added in the PR... |
Cc admin @derberg |
I think it is all about tests and it is completely fine if you just add |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Thanks @smoya 👍 |
🎉 This PR is included in version 2.1.0-next-major-spec.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This PR finishes #611