Binding interface does not support excess properties

[oviecodes]

Describe the bug

The OldServer, ServerV2, and Server classes do not support excess properties on the Binding interface.

How to Reproduce

using "@asyncapi/parser": "^2.0.0-next-major.15"

import { OldAsyncAPIDocument, OldServer } from '@asyncapi/parser'

//inside an exported class
private _AsyncAPIServer: OldServer

get AsyncAPIServer(): OldServer {
    return this._AsyncAPIServer
}

//in another file with a class that extends the class above

const mqttServerBinding = this.AsyncAPIServer.binding('mqtt')
const mqtt5ServerBinding = this.AsyncAPIServer.binding('mqtt5')

const serverBinding = protocolVersion === 5 ? mqtt5ServerBinding : mqttServerBinding

mqtt.connect({
      ...
      clientId: serverBinding?.clientId ?? auth?.clientId,
      clean: serverBinding?.cleanSession,
      ...
})

An error is thrown that clientId does not exist on type Binding.

The Binding interface

Expected behavior

The Binding interface should support excess properties possibly by using [propName: string]: any;

[github-actions]

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

[magicmatatjahu]

@oviecodes Do you wanna add PR?

[oviecodes]

Alright @magicmatatjahu , I'll do so

[oviecodes]

@magicmatatjahu I also noticed that the AsyncApiDocumentV2 interface doesn't have a couple of properties the old AsyncApiDocument has e.g serverNames(), channel(), channelNames() properties. Was this done on purpose?

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

[jonaslagoni]

Cc @smoya can you remember whether this was addressed in one of the recent changes?

[smoya]

Cc @smoya can you remember whether this was addressed in one of the recent changes?

No, you will still need to do something like (mqttServerBinding as any).clientId to fetch the value.

In the new API, this is solved by the binding.value() method signature: <V = T>(): V

@oviecodes are you ok creating the PR for this? I'm +1 to add the [propName: string]: any; to both v2 and v3 BindingInterface spec types.
cc @magicmatatjahu

[oviecodes]

yeah @smoya , just waiting for @magicmatatjahu to respond then it's a go

[magicmatatjahu]

Go with this.

[oviecodes]

Alright, I'll create a PR

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️