Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to fix randomly failing tests during development #558

Closed
derberg opened this issue May 25, 2022 · 8 comments · Fixed by #575
Closed

Document how to fix randomly failing tests during development #558

derberg opened this issue May 25, 2022 · 8 comments · Fixed by #575
Labels
area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. enhancement New feature or request good first issue Good for newcomers released on @next-major-spec released stale

Comments

@derberg
Copy link
Member

derberg commented May 25, 2022

Reason/Context

Sometimes on Windows tests fail. We fixed it on CI but contributors are still affected on local development.

Description

@derberg derberg added the enhancement New feature or request label May 25, 2022
@derberg
Copy link
Member Author

derberg commented May 25, 2022

/gfi docs

@asyncapi-bot asyncapi-bot added area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. good first issue Good for newcomers labels May 25, 2022
@Ruchip16
Copy link
Contributor

Ruchip16 commented Aug 1, 2022

Hey, @derberg I have documented the above points in the readme section in my forked repo, check once and let me know if that's what the issue is stating or if it needs any improvement further and I can make a final PR for the same.
https://github.com/Ruchip16/parser-js/blob/master/README.md/#develop

@jonaslagoni
Copy link
Member

Hey @Ruchip16, @derberg is on vacation at the moment, so I am jumping in if you don't mind?

Since you have already commited the changes to your branch, can I get you to create a PR? That way it is easier to see the changes you propose and we can review/discuss it directly 🙂 It's the easiest way to get feedback 👍

Let me know if you have any issue creating one!

@Ruchip16
Copy link
Contributor

Ruchip16 commented Aug 2, 2022

Yess @jonaslagoni suree, I have made a PR, check it once and let me know if it needs any improvement further

@github-actions
Copy link

github-actions bot commented Dec 1, 2022

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.1.0-next-major-spec.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. enhancement New feature or request good first issue Good for newcomers released on @next-major-spec released stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants