Generator for dotnet System.Text.Json.JsonConverter produces code that does not match case settings and does not compile.

[tomwolanski]

Describe the bug

When generating a model the property name setting was kept to default value (PascalCase for dotnet). An option to generate json converter was also set. The output code does not compile due to property case mismatch.

How to Reproduce

Reproduced in modelina playground:

The sample api documment:

{
    "asyncapi": "2.5.0",
    "info": {
        "title": "Streetlights API",
        "version": "1.0.0"
    },
    "channels": {
        "light/measured": {
            "publish": {
                "summary": "Inform about environmental lighting conditions for a particular streetlight.",
                "operationId": "onLightMeasured",
                "message": {
                    "name": "LightMeasuredEvent",
                    "payload": {
                        "type": "object",
                        "$id": "LightMeasuredEvent",
                        "required": [ "id" ],
                        "properties": {
                            "id": {                                        // <-- camel case in naming
                                "type": "integer",
                                "minimum": 10
                            },
                            "sentAt": {
                                "type": "string",
                                "format": "date-time"
                            }
                        }
                    }
                }
            }
        }
    }
}

with code generator options:

const generator = new CSharpGenerator({
  indentation: {
    type: IndentationTypes.SPACES
  },
  collectionType: 'Array',
  autoImplementedProperties: true,
  namespace: 'asyncapi.models',
  nullable: true,
 presets: [
  CSHARP_JSON_SERIALIZER_PRESET
]
});

produces model code with expected property format:

[JsonConverter(typeof(LightMeasuredEventConverter))]
public class LightMeasuredEvent
{
	public int Id { get; set; }                             // <-- pascal case in model
	public string? SentAt { get; set; }
	public Dictionary<string, dynamic>? AdditionalProperties { get; set; }
}

the conventer, however uses camel case naming to access those properties:

// ...
if (value.id != null)
{
	// write property name and let the serializer serialize the value itself
	writer.WritePropertyName("id");
	JsonSerializer.Serialize(writer, value.id, options);   // <-- camel case in converter,  should be "value.Id"
}
if (value.sentAt != null)
{
	// write property name and let the serializer serialize the value itself
	writer.WritePropertyName("sentAt");
	JsonSerializer.Serialize(writer, value.sentAt, options);   // <-- camel case in converter, should be "value.SentAt"
}
// ..

Expected behavior

The json converter code produced by the generator should be valid and possible to compile.

[github-actions]

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

[jonaslagoni]

You are right, thanks for the issue @tomwolanski, nice description!

Yea, the code tries to use the property name instead of the accessor name, which is always pascal case:

modelina/src/generators/csharp/renderers/ClassRenderer.ts

Line 126 in d7ccab8

const formattedAccessorName = pascalCase(property.propertyName);

So this line here:

modelina/src/generators/csharp/presets/JsonSerializerPreset.ts

Line 33 in d7ccab8

const modelInstanceVariable = `value.${propertyName}`;

Needs to change to pascal case as well, at least that's what I currently think is wrong, feel free to correct me @tomwolanski 🙂

Wanna provide this change @tomwolanski?

[asyncapi-bot]

🎉 This issue has been resolved in version 1.8.10 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[jonaslagoni]

@all-contributors please add @tomwolanski for bug

[allcontributors]

@jonaslagoni

I've put up a pull request to add @tomwolanski! 🎉