Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add summernote editor #67

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add summernote editor #67

wants to merge 3 commits into from

Conversation

VaibhavSaini19
Copy link
Member

No description provided.

@VaibhavSaini19 VaibhavSaini19 linked an issue Oct 2, 2020 that may be closed by this pull request
Add a WYSIWYG text editor for sending an receiving stuff after sanitizing inputs #45
Open
@gridhead gridhead added enhancement New feature or request hacktoberfest Contribute to the notion of open-source this October! labels Oct 3, 2020
gridhead
gridhead requested changes Oct 3, 2020
View reviewed changes
Copy link
Member

@gridhead gridhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not look very good. You are directed to change the way the send button looks.
image

Also, the "sending on keypress" has seemingly broken with this introduction. Make sure that the user is able to head to next line using SHIFT+ENTER and send messages using ENTER.

gridhead
gridhead requested changes Oct 3, 2020
View reviewed changes
Copy link
Member

@gridhead gridhead left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are also suggested to not display the formatting bar at the top of the message textbox. We are to let the user know that the shortcuts like Ctrl+B works for emphasising the text and so on.

image

We are better off without advanced features.

(If it makes it convenient, please scratch off summernote for something more simplistic. We can change the issue for it does not comply with the requirements anymore)

@VaibhavSaini19
Copy link
Member Author

I will override the keypress to make "enter" submit and "Shift+enter" to insert a new line. I will also hide the toolbar.
Could you explain how you want the send button to look?

@gridhead
Copy link
Member

gridhead commented Oct 3, 2020

I will override the keypress to make "enter" submit and "Shift+enter" to insert a new line.

Sounds good.

I will also hide the toolbar.

Yes. Hiding is appreciated. Let the functionalities persist though.

Could you explain how you want the send button to look?

Just like the way it used to before.

@VaibhavSaini19
Copy link
Member Author

@t0xic0der I was anticipating that, so did the desired changes in the last commit already. Please check it out

@gridhead
Copy link
Member

LGTM. Approved the changes. Will merge shortly.

gridhead
gridhead approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@gridhead gridhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions.

@gridhead gridhead added hacktoberfest-accepted Thank you for your contributions and removed enhancement New feature or request hacktoberfest Contribute to the notion of open-source this October! labels Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gridhead gridhead gridhead approved these changes

Assignees

@VaibhavSaini19 VaibhavSaini19

Labels
hacktoberfest-accepted Thank you for your contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a WYSIWYG text editor for sending an receiving stuff after sanitizing inputs
2 participants
@VaibhavSaini19 @gridhead