Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sphinx class inheritance diagrams not linking classes correctly #48

Closed
hamogu opened this issue Sep 13, 2018 · 5 comments
Closed

Sphinx class inheritance diagrams not linking classes correctly #48

hamogu opened this issue Sep 13, 2018 · 5 comments

Comments

@hamogu
Copy link
Member

hamogu commented Sep 13, 2018

E.g. at https://astropy.readthedocs.io/en/latest/visualization/index.html#module-astropy.visualization

click on any class in the graph-viz Diagram - None of them work, because there is a "/latest/" missing in the url. I'm reporting this here, but I'm not entirely sure if this is a sphinx-automodapi issue or related to some configuration in astropy itself.

@nritsche
Copy link

https://dias.readthedocs.io/en/rn-docs/dev/reference.html

The diagram links point to a different .rst than the class name links.

@bsipocz
Copy link
Member

bsipocz commented May 18, 2022

I've run into the broken links again, today.

It's useful to link to these following issues as PRs and most of the relevant discussions happened on them:

astropy/astropy#4935

and upstream fixes and more discussions on how it should be fixed instead here, in this extension:
sphinx-doc/sphinx#2484
sphinx-doc/sphinx#6454

@bsipocz bsipocz changed the title Links in inheritance diagrams broken Sphinx class inheritance diagrams not linking classes correctly May 18, 2022
@ayshih
Copy link
Contributor

ayshih commented Jun 18, 2022

This is actually a bug in Sphinx after all. See sphinx-doc/sphinx#10576

@pllim
Copy link
Member

pllim commented Jun 20, 2022

Thanks for investigating and opening upstream fix!

@pllim
Copy link
Member

pllim commented Aug 10, 2023

I think this is fixed by #172

@pllim pllim closed this as completed Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants