Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move astropy.samp to pyvo #155

Open
pllim opened this issue Jun 21, 2019 · 8 comments · May be fixed by #527
Open

Move astropy.samp to pyvo #155

pllim opened this issue Jun 21, 2019 · 8 comments · May be fixed by #527
Assignees

Comments

@pllim
Copy link
Member

pllim commented Jun 21, 2019

Did we discuss this at IVOA Interop? cc @astrofrog

@astrofrog
Copy link
Member

We didn't really discuss it, but it's certainly an option! (I'd argue that other things like VOTable belong in the core package, but no strong opinions on astropy.samp)

@pllim
Copy link
Member Author

pllim commented Jun 21, 2019

I also agree that votable should stay in the core since it is very much integrated with the unified I/O.

@funbaker
Copy link
Contributor

This would also require to de-couple the submodules from the top-module.
(It's not necessary to import the whole dal stack for just broadcasting a table.)

@pllim
Copy link
Member Author

pllim commented Dec 12, 2019

At Astropy Coordination Meeting 2019, this was decided to be a good idea. But io.votable would stay in astropy.

@pllim pllim changed the title Move astropy.samp to pyvo? Move astropy.samp to pyvo Dec 12, 2019
@pllim
Copy link
Member Author

pllim commented Jun 17, 2020

Is there a roadmap for this?

@tomdonaldson tomdonaldson self-assigned this Sep 22, 2022
@tomdonaldson
Copy link
Contributor

Renewing this effort...

The goal: We would like to deprecate then removeastropy.samp from astropy in favor of SAMP capabilities in pyvo.

Note that pyvo/samp depends on astropy.samp, so that reference will need to change. This work should ensure that existing pyvo SAMP capabilities are retained and that astropy SAMP capabilities are supported and documented.

For more details on this see the notes from unmerged PR #239.

@tomdonaldson tomdonaldson added this to the v1.5 milestone Sep 22, 2022
@pllim
Copy link
Member Author

pllim commented Sep 26, 2022

Please cross link the new PR here when you have one. Thank you so much! 🙏

@bsipocz
Copy link
Member

bsipocz commented Apr 12, 2023

I'm removing the milestone from this one as this is not a thing that should block the 1.5 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants