Add missing attribute 'DbtSourceGcpCloudRunJobOperator' in module 'cosmos.operators.gcp_cloud_run_job' #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 'cosmos.operators.gcp_cloud_run_job'
dosubot
bot
added
the
size:S
dosubot
bot
added
the
area:execution
✅ Deploy Preview for sunny-pastelito-5ecb04 canceled.
|
|
Hello @tatiana My PR is ready for a review. |
tatiana
reviewed
Oct 31, 2024
There was a problem hiding this comment.
@anai-s this looks great! Thanks for reporting the issue and creating the PR to fix it.
Could we also have a test related to this?
It may be possible to accomplish this by extending an existing test, such as test_dbt_gcp_cloud_run_job_build_command:
https://github.com/astronomer/astronomer-cosmos/blob/main/tests/operators/test_gcp_cloud_run_job.py
Tests are important so we make sure we don't have a regression on this in the future.
|
@tatiana sure I will add the test! Thank you for the review. |
|
@tatiana I added the test for the module |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this PR add a missing attribute
DbtSourceGcpCloudRunJobOperatorincosmos.operators.gcp_cloud_run_job.pyto be able to use the source_rendering_behavior params incosmos.config.RenderConfigclass with the new GCP_CLOUD_RUN_JOB execution mode (available in 1.7.0) .Related Issue(s)
closes #1276
Breaking Change?
Checklist