New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection `.none` and `.unavailable` are mixed in the code #393

Open

pjechris opened this issue Jun 26, 2023 · 0 comments

pjechris commented Jun 26, 2023 •

edited

Loading

Hi,

Reading quickly the code I found some places where .none and .unavailable are mixed:

Connection.description: unavailable is "no connection" and .none is... "unavailable" 🤔
deprecated isReachable: comment says to compare to .none and code compares to... .unavailable 🤔

Screenshot 2023-06-26 at 17 02 36

Screenshot 2023-06-26 at 17 23 02

It makes things very unclear about what's the difference between the two (and misleading).

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment