Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List bullets in table of contents don't render in Safari #96

Open
sevenseacat opened this issue Feb 13, 2023 · 1 comment
Open

List bullets in table of contents don't render in Safari #96

sevenseacat opened this issue Feb 13, 2023 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@sevenseacat
Copy link
Collaborator

Brief Description

When adding the necessary classes to make the text overflow “…” work, it makes the list bullets (both numbers and alphas) disappear in Safari only, both web and mobile.

Steps to reproduce the bug

Visit any page with a table of contents, eg. https://ash-hq.org/docs/guides/ash/latest/tutorials/get-started

In Firefox/Chrome the list markers appear, but in Safari they do not.

Context

Screenshot 2023-02-13 at 11 11 52 am

@sevenseacat sevenseacat added the bug Something isn't working label Feb 13, 2023
@sevenseacat
Copy link
Collaborator Author

The HTML used in this table of contents is generated here -> https://github.com/ash-project/ash_hq/blob/main/lib/ash_hq/docs/extensions/render_markdown/post_processors/table_of_contents_generator.ex

So any fix to this will probably tweaking what classes get added to the li elements, both first and second levels, on both

"text-primary-light-600 dark:text-primary-dark-400 text-ellipsis overflow-hidden block"}
and
"text-primary-light-600 dark:text-primary-dark-400 block text-ellipsis overflow-hidden"}
.

Any new classes that get added may need to also be added to the Tailwind config in tailwind.config.js, as they will be stored as part of the database content and not part of the application UI code.

@sevenseacat sevenseacat added the good first issue Good for newcomers label Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant