Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tool bin executable if not set from tarball #22

Open
poikilotherm opened this issue Jan 6, 2021 · 1 comment
Open

Make tool bin executable if not set from tarball #22

poikilotherm opened this issue Jan 6, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@poikilotherm
Copy link

poikilotherm commented Jan 6, 2021

Is your feature request related to a problem? Please describe.

If the distributor of a tool does not ship the tool bin with executable bit set or in other circumstances, the install will fail because of the missing permission bit. A plugin developer has to add a chmod +x on its own, instead of the template already taking this burden.

Describe the solution you'd like

Instead of creating chore work, maybe not fail when exec perm check fails, but try to set +x first. If the file itself is missing due to a failed install, it will still fail, which seems fine.

Describe alternatives you've considered

Let every plugin dev stumble over package maintainers not setting an exec bit and re-iterate with adding a chmod.

@poikilotherm poikilotherm added the enhancement New feature or request label Jan 6, 2021
@jthegedus
Copy link
Collaborator

Happy for a PR to update this behaviour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants