Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gelato should fail with an informative error message if the user supplies a MATSim events file where link events appear out of chronological order #22

Open
mfitz opened this issue Feb 13, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mfitz
Copy link
Contributor

mfitz commented Feb 13, 2024

As per this discussion, Gelato throws a LinkLogPassengerConsistencyException and terminates if the events file contains link events that do not appear in chronological order. Although this is the desired behaviour, the messaging to the user does not explain what they need to do (sort their events file into chronological order) to correct the error, so the user experience is a confusing one.

When the app terminates in this way, it should clearly explain the cause of the error and the action that the user should take. We should also document this requirement of the events file in the README.

@mfitz mfitz added enhancement New feature or request good first issue Good for newcomers labels Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant