Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite batch counter from settings file; No.... Does not overwrite batch prefix. #372

Closed
arkenamun opened this issue Jul 3, 2019 · 2 comments
Labels
Milestone

Comments

@arkenamun
Copy link

Expected Behavior

Batch prefix may continue to be loaded from settings file, even if we choose not to overwrite batch counter from the settings file.

Overwrite Batch Counter dialogue

Actual Behavior

If we say 'NO' to 'Overwrite your current batch counter h2839 by c2749 from the settings file?' then neither the batch (2839) nor prefix (h) are overwritten.

That seems reasonable and logical according to the question, yet may not be practical if the user uses the prefix to record which settings file/type of roast is being produced in this session. The user may be using multiple settings files, yet still wishes to keep each batch number sequential and unique irrespective of type of coffee roasted.

I think it makes sense that the prefix is always loaded as this is a static setting of the settings file that, along with the other static settings, is chosen by the user. Unlike the batch number which is expected to change dynamically with roasting.

N.B. For background, in my use case, I have 2 settings files. The main difference is in the Axes settings, one has higher time and temperature for a hotter, longer, dark roast (2nd crack). The other setting file is for 3rd wave lighter roasts. But also some of my settings for over-temperature alarms and aspects of roast automation are different.

The, recently added, display of batch number during roasting has the prefix and is great reassurance at the start of roasting that we have remembered to open the correct settings.

Specifications

  • Artisan Version: 2.0.0
  • Artisan Build (number in brackets shown in the about box): a0a1fac
  • Platform (Mac/Windows/Linux + OS version): W10
  • Connected devices or roasting machine: Phidgets and Modbus
@MAKOMO
Copy link
Member

MAKOMO commented Jul 5, 2019

Thanks for your report. While I could think of users that might complain if the prefix does change with the loaded settings, I will follow your proposal and treat the batch prefix as any other application setting. Just the pure batch counter (number) will be treated special then.

@MAKOMO MAKOMO added this to the v2.1 milestone Jul 6, 2019
MAKOMO added a commit that referenced this issue Jul 6, 2019
@MAKOMO
Copy link
Member

MAKOMO commented Jul 6, 2019

Fixed by Commit 003724c

@MAKOMO MAKOMO closed this as completed Jul 6, 2019
@MAKOMO MAKOMO added bug and removed in process labels Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants