Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmd-S on Mac #245

Closed
InvisibleOrdinary opened this issue Sep 26, 2018 · 3 comments
Closed

Cmd-S on Mac #245

InvisibleOrdinary opened this issue Sep 26, 2018 · 3 comments
Labels

Comments

@InvisibleOrdinary
Copy link

Expected Behavior

Cmd-S is save file

Actual Behavior

Cmd-S works to both toggle sliders on & off, and also save file. This is confusing to have the same command work for different actions. toggle sliders should be a different cmd- shortcut, particularly because the shortcuts seem to be active at different times… (?)

This was logged as an issue in a prior issue, and was supposed to be included in 1.3.1 release, however it doesn't seem that this was included. Is it still on the roadmap?

Steps to Reproduce the Problem

Specifications

  • Artisan Version: Artisan 1.3.1 (1)
  • Artisan Build (number in brackets shown in the about box): (1)
  • Platform (Mac/Windows/Linux + OS version): Mac OS 10.14
  • Connected devices or roasting machine: Phidgets 1048 w/ 2 probes

Please attach your current Artisan settings file (as exported via menu Help >> Save Setings as *.aset) file.
Please attach any relevant Artisan *.alog profiles.

Note that you need either add a .txt extension or zip the files before uploading. Otherwise you will receive a "Not a supported file type" error on uploading.

@MAKOMO MAKOMO added the invalid label Sep 27, 2018
@MAKOMO
Copy link
Member

MAKOMO commented Sep 27, 2018

CMD-S is Save file, CMD-SHIFT-S is SaveAs (added in v1.3.1, Issue #194 ) and just S shows/hides the sliders. There is no overlap!

@MAKOMO MAKOMO closed this as completed Sep 27, 2018
@InvisibleOrdinary
Copy link
Author

Hi Marko,

There is actually overlap here. I am able to reproduce consistently. Which is why I keep submitting this…

Best I can identify is that the roast has to be in an OFF state for cmd-s to trigger save file. Otherwise, (in ON or START state) it is overridden by toggle sliders.

The same holds true for cmd ⇧ s toggling the sliders instead of save as

Please verify that you can reproduce this.

Artisan Version: Artisan 1.3.1 (1)
Artisan Build (number in brackets shown in the about box): (1)
Platform (Mac/Windows/Linux + OS version): Mac OS 10.14

@MAKOMO
Copy link
Member

MAKOMO commented Oct 3, 2018

In ON and OFF state you cannot save a file (mostly because there is no complete file to be saved yet) an the Save menu items are therefore disabled, thus there is no overlap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants