Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.3 Alarms don't save and crash Artisan #182

Closed
DavidFW1960 opened this issue Apr 18, 2018 · 17 comments
Closed

Version 1.3 Alarms don't save and crash Artisan #182

DavidFW1960 opened this issue Apr 18, 2018 · 17 comments
Labels

Comments

@DavidFW1960
Copy link

Expected Behavior

Alarms should be able to be saved after editing Temperature

Actual Behavior

Pressing save crashes software and does not save alarm

Steps to Reproduce the Problem

Open Alarms and edit a Temperature and press save
1.Open Alarms
2.Enter or Edit a Temperature
3.Save

Specifications

  • Artisan Version: 1.3.0
  • Artisan Build (number in brackets shown in the about box):ca3c5f1
  • Platform (Mac/Windows/Linux + OS version):Linux, Raspbian Stretch
  • Connected devices or roasting machine: Hottop but not relevant

Please attach your current Artisan settings file (as exported via menu Help >> Save Setings as *.aset) file.
Please attach any relevant Artisan *.alog profiles.
Saving Settings also caused a crash just now.
I zipped a settings and alarm file. It had a bz2 extension but i renamed it to zip as I could not uppload it otherwise.

profile.zip

@rpaulo
Copy link
Member

rpaulo commented Apr 18, 2018

When it crashes, can you show us what are the crash details?

@DavidFW1960
Copy link
Author

It crashes to the desktop. no error.

@DavidFW1960 DavidFW1960 changed the title Version 1.3 Alarms don save and crash Artisan Version 1.3 Alarms don't save and crash Artisan Apr 27, 2018
@MAKOMO MAKOMO added the RPi label May 7, 2018
@samtsai5212
Copy link

permission problem, try run sudo artisan

@DavidFW1960
Copy link
Author

It’s not a permissions error.
You don’t sudo in the GUI.
This worked perfectly in 1.2 and I can manually edit the alarm file.

@MAKOMO
Copy link
Member

MAKOMO commented May 8, 2018

v1.2 was build on a totally different stack still using Python2 and Qt4. v1.3 runs on Python3 and Qt5.
The v1.3 builds seem to have an issue opening a file selector on some hardware/software combinations (not on mine!?). See also Issue #188 and Issue #187. Could you please run the following two commands and post the results here?

# cat /etc/os-release
PRETTY_NAME="Raspbian GNU/Linux 9 (stretch)"
NAME="Raspbian GNU/Linux"
VERSION_ID="9"
VERSION="9 (stretch)"
ID=raspbian
ID_LIKE=debian
HOME_URL="http://www.raspbian.org/"
SUPPORT_URL="http://www.raspbian.org/RaspbianForums"
BUG_REPORT_URL="http://www.raspbian.org/RaspbianBugs"
# cat /proc/cpuinfo | grep 'Revision' | awk '{print $3}' | sed 's/^1000//'
a22082

@DavidFW1960
Copy link
Author

DavidFW1960 commented May 9, 2018

cat /etc/os-release

PRETTY_NAME="Raspbian GNU/Linux 9 (stretch)"
NAME="Raspbian GNU/Linux"
VERSION_ID="9"
VERSION="9 (stretch)"
ID=raspbian
ID_LIKE=debian
HOME_URL="http://www.raspbian.org/"
SUPPORT_URL="http://www.raspbian.org/RaspbianForums"
BUG_REPORT_URL="http://www.raspbian.org/RaspbianBugs"

cat /proc/cpuinfo | grep 'Revision' | awk '{print $3}' | sed 's/^1000//'

a02082

@DavidFW1960
Copy link
Author

DavidFW1960 commented May 9, 2018

ok it seems it might be settings if I load as sudo from terminal I don't get an error.

On the desktop I can right click on Artisan Icon and select properties. I can see the following:

image

Wonder if I should change those for execute to anybody and change content to anybody as well?

EDIT: Tried changing and still crashes.

@DavidFW1960
Copy link
Author

as per post in the crash thread from @samtsai5212 this fixes it permanently:

Artisan 1.3 crashes probably because it tried to save something without permission. Try to run Artisan in terminal with root privilege:
sudo artisan

If you want to make it permanent, run the following:
sudo nano /usr/share/applications/artisan.desktop
find the line:
Exec=artisan %U
Change to:
Exec=sudo artisan %U
press ctrl+X then
press Y then enter

@rpaulo
Copy link
Member

rpaulo commented May 9, 2018

Can you find out which file Artisan is trying to save? Maybe strace will help.

@DavidFW1960
Copy link
Author

DavidFW1960 commented May 9, 2018

?? It's the alarm file that I was editing. It's located in the home/pi folder so no permission issue you'd think.

@rpaulo
Copy link
Member

rpaulo commented May 9, 2018

If it was a permissions problem saving the alarms, we would see an exception and it would be handled by our exception handler, but in this case it looks like the software aborts.

@DavidFW1960
Copy link
Author

Yes exactly - crashes out to the desktop with no error.

@MAKOMO
Copy link
Member

MAKOMO commented May 9, 2018

The issue seems to be caused by a file access that files on opening a file selector with in the GUI libs of the underlying QT. This might be caused by a missing lib file in the Artisan RPi bundle and thus be a build issue. Running Artisan as root is a valid workaround for now, while I don't understand yet why this works. We are investigating...

@DavidFW1960
Copy link
Author

Thanks @MAKOMO Much appreciated

@MAKOMO
Copy link
Member

MAKOMO commented May 13, 2018

I close this one as it seems to have the same cause then Issue #187

@MAKOMO MAKOMO closed this as completed May 13, 2018
@DavidFW1960
Copy link
Author

This looks ok now in 1.3.1 and also I note that installing 1.3.1 removed the sudo I added to the command in /usr/share/applications/artisan.desktop

Thanks!

@MAKOMO
Copy link
Member

MAKOMO commented May 21, 2018

Thanks for double checking David!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants