Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cooldown Period between Retries #136

Open
jonnyreeves opened this issue Nov 16, 2011 · 1 comment
Open

Cooldown Period between Retries #136

jonnyreeves opened this issue Nov 16, 2011 · 1 comment

Comments

@jonnyreeves
Copy link

A useful feature addition would be a 'cooldown' or 'backoff' period between retries in LoadingItem which would force the loader to wait a specified amount of time before attempting to load the resource again.

Although this sounds like an odd request - requests for resources from Amazon S3 will sometimes mysteriously fail for a user, yet if you were to retry the request 5 seconds later it would work (see Amazon's own S3 Best Practices document).

An example of the syntax could be: bulkInstance.add("asset.png", {maxTries: 5, cooldown: 2000});

@arthur-debert
Copy link
Owner

Hey Jonny.

This sounds good. I definitely understand the use case.
If you can wipe up a patch, I'll definitely pull. The only caveat is that I won't pull without tests, so if you can include a test, then we should be good. This feature is probably tricky to test though... if you need help getting the test suite & runner up, just ping me .

When I wrote BulkLoader, all tests ;libs sucked at having asynchronous setup , so i kind of rolled my own...

Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants