-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathPropertyVerifier.cs
671 lines (590 loc) · 22.8 KB
/
PropertyVerifier.cs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
using System;
using System.Collections.Generic;
using System.Linq;
namespace ModelPropertyChecker
{
public class PropertyException : Exception
{
public bool isError { get; } = true; //Can also be warning
public string propertyName { get; }
public PropertyException() {}
public PropertyException(string propertyName, string message) : base(message)
{
this.propertyName = propertyName;
}
public PropertyException(string message, Exception inner) : base(message, inner){}
public PropertyException(string propertyName, string message, bool isError) : base(message)
{
this.propertyName = propertyName;
this.isError = isError;
}
public override string ToString()
{
return Message;
}
}
interface PropertyCondition
{
bool verifyProperty(Model model, Tuple<string, string> property, LOD sourceLod);
}
class PropVerify_IsNotEmpty : PropertyCondition
{
public bool verifyProperty(Model model, Tuple<string, string> property, LOD sourceLod)
{
if (string.IsNullOrWhiteSpace(property.Item2))
throw new PropertyException(property.Item1,"Property value is empty.");
return true;
}
}
class PropVerify_IsNumber : PropertyCondition
{
public bool verifyProperty(Model model, Tuple<string, string> property, LOD sourceLod)
{
var isNumeric = double.TryParse(property.Item2, out double n);
if (!isNumeric)
throw new PropertyException(property.Item1,"Property is not a number.");
return true;
}
}
class PropVerify_IsBoolean : PropertyCondition
{
public bool verifyProperty(Model model, Tuple<string, string> property, LOD sourceLod)
{
if (property.Item2 == "0" || property.Item2 == "1") return true;
var isNumeric = float.TryParse(property.Item2, out float n);
if (!isNumeric)
throw new PropertyException(property.Item1,"Property is not a boolean. Only 0/1 values are allowed");
//It's still a number, but outside of the valid range
throw new PropertyException(property.Item1,"Property is outside of range for boolean. Only 0/1 values are allowed", false);
//#TODO suggest quick fix if it's yes/no or true/false
}
}
class PropVerify_IsLodIndex : PropertyCondition
{
private readonly float lodAdd;
private readonly bool needAdd;
//adds a number to the value found in the property
public PropVerify_IsLodIndex(float add = 0, bool optionalAdd = false)
{
lodAdd = add;
needAdd = !optionalAdd;
}
public bool verifyProperty(Model model, Tuple<string, string> property, LOD sourceLod)
{
float.TryParse(property.Item2, out float n);
float actualLod = n + lodAdd;
if (model.lods.ContainsKey(actualLod)) return true;
if (!needAdd)
{
if (!needAdd) //Check if value is already lod resolution
{
if (model.lods.ContainsKey(n)) return true;
}
throw new PropertyException(property.Item1, $"Property does not match a existing lod. Couldn't find lod {actualLod} or {n + lodAdd}");
}
throw new PropertyException(property.Item1, $"Property does not match a existing lod. Couldn't find lod {actualLod}");
}
}
class PropVerify_IsOnGeoLod : PropertyCondition
{
public bool verifyProperty(Model model, Tuple<string, string> property, LOD sourceLod)
{
if (sourceLod.resolution == 1e13f) //#TODO if there is no geo lod, check that it's in the first lod.
return true;
else
{
if (
!model.lods.ContainsKey(1e13f) //No geo lod. Check if property is in first lod.
&& model.lods.First().Value != sourceLod //Not on first lod! Error.
)
throw new PropertyException(property.Item1,"Property is not in Geometry LOD");
return true; //No geo lod, but property is on first lod. All fine.
}
}
}
class PropVerify_IsOnVisLod : PropertyCondition
{
public bool verifyProperty(Model model, Tuple<string, string> property, LOD sourceLod)
{
if ((float)sourceLod.resolution < 901)
return true;
else
throw new PropertyException(property.Item1, "Property is not in Resolution LOD");
//#TODO log name of which lod it was found on.
}
}
class PropVerify_IsEnum : PropertyCondition
{
private readonly HashSet<string> possibleValues;
public PropVerify_IsEnum(HashSet<string> values) => possibleValues = values;
public bool verifyProperty(Model model, Tuple<string, string> property, LOD sourceLod)
{
if (possibleValues.Contains(property.Item2.ToLower()))
return true;
else
throw new PropertyException(property.Item1,$"Property does not match Enum. Value \"{property.Item2}\" is not valid");
}
}
class PropVerify_ExpectPropertyExists : PropertyCondition
{
private readonly string propertyName;
public PropVerify_ExpectPropertyExists(string name) => propertyName = name;
public bool verifyProperty(Model model, Tuple<string, string> property, LOD sourceLod)
{
if (sourceLod.properties.ContainsKey(propertyName))
return true;
else
throw new PropertyException(property.Item1,$"Property is only valid if property \"{propertyName}\" exists");
}
}
class PropVerify_ExpectPropertyNotExist : PropertyCondition
{
private readonly string propertyName;
public PropVerify_ExpectPropertyNotExist(string name) => propertyName = name;
public bool verifyProperty(Model model, Tuple<string, string> property, LOD sourceLod)
{
if (sourceLod.properties.ContainsKey(propertyName))
throw new PropertyException(property.Item1,$"Property is only valid if property \"{propertyName}\" doesn't exist");
else
return true;
}
}
class PropVerify_ExpectPropertyValue : PropertyCondition
{
private readonly string propertyName;
private readonly string propertyValue;
public PropVerify_ExpectPropertyValue(string name, string value)
{
propertyName = name;
propertyValue = value;
}
public bool verifyProperty(Model model, Tuple<string, string> property, LOD sourceLod)
{
if (sourceLod.properties.ContainsKey(propertyName))
{
var value = sourceLod.properties[propertyName];
throw new PropertyException(property.Item1,$"Property is only valid if property \"{propertyName}\" is set to value \"{propertyValue}\". Current value is \"{value}\"");
//#TODO suggest quick fix
}
throw new PropertyException(property.Item1,$"Property is only valid if property \"{propertyName}\" exists");
}
}
class PropVerify_ObsoleteValue : PropertyCondition
{
private readonly string propertyValue; //#TODO add a "cause"
public PropVerify_ObsoleteValue(string value) => propertyValue = value;
public bool verifyProperty(Model model, Tuple<string, string> property, LOD sourceLod)
{
if (property.Item2.Equals(propertyValue, StringComparison.CurrentCultureIgnoreCase))
throw new PropertyException(property.Item1,$"Property value \"{property.Item2}\" is obsolete");
return true;
}
}
class PropVerify_LogicOr : PropertyCondition
{
private readonly PropertyCondition first;
private readonly PropertyCondition second;
public PropVerify_LogicOr(PropertyCondition item1, PropertyCondition item2)
{
first = item1;
second = item2;
}
public bool verifyProperty(Model model, Tuple<string, string> property, LOD sourceLod)
{
try
{
var result = first.verifyProperty(model, property, sourceLod);
if (result) return true;
} catch (PropertyException exception)
{
try
{
var result = second.verifyProperty(model, property, sourceLod);
if (result) return true;
} catch (PropertyException exception2)
{
throw new PropertyException(property.Item1,$"Or Condition failed. Either: {exception.Message} or {exception2.Message}");
}
}
return false;
}
}
static class PropertyVerifier
{
private static List<PropertyCondition> CreateBooleanCondition(bool forceGeometryLod = false)
{
return new List<PropertyCondition>
{
new PropVerify_IsNotEmpty(),
new PropVerify_IsBoolean(),
forceGeometryLod ? new PropVerify_IsOnGeoLod() : null
};
}
private static readonly Dictionary<string, List<PropertyCondition>> verifiers = new Dictionary<string, List<PropertyCondition>>
{
{
"aicovers",
CreateBooleanCondition(true)
},
{
"armor",
new List<PropertyCondition>
{
new PropVerify_IsNotEmpty(),
new PropVerify_IsOnGeoLod(),
new PropVerify_IsNumber()
}
},
{
"autocenter",
CreateBooleanCondition(true)
},
{
"buoyancy",
CreateBooleanCondition(true)
},
{
"canbeoccluded",
CreateBooleanCondition(true)
},
{
"canocclude",
CreateBooleanCondition(true)
},
{
"class",
new List<PropertyCondition>
{
new PropVerify_IsNotEmpty(),
new PropVerify_IsOnGeoLod(),
new PropVerify_IsEnum(
new HashSet<string>
{
//Trees
"treehard",
"treesoft",
"bushhard",
"bushsoft",
"forest",
//houses
"house",
"church",
"road",
"thing",
"land_decal",
"thingx",
"clutter",
"bridge",
"streetlamp",
"housesimulated",
"tower",
"vehicle",
"breakablehouseanimated",
"pond",
"man",
"none",
"building"
})
}
},
{
"damage",
new List<PropertyCondition>
{
new PropVerify_IsNotEmpty(),
new PropVerify_IsOnGeoLod(),
new PropVerify_IsEnum(
new HashSet<string>
{
"building", //#TODO order alphabetically and make sure we got all of them
"no",
"tent",
"tree",
"wall",
"wreck"
})
}
},
{
"dammage", //#TODO add a warning that this should be renamed to damage
new List<PropertyCondition>
{
new PropVerify_IsNotEmpty(),
new PropVerify_IsOnGeoLod(),
new PropVerify_IsEnum(
new HashSet<string>
{
"building", //#TODO order in some way and make sure we got all of them
"no",
"tent",
"tree",
"wall",
"wreck"
})
}
},
{
"drawimportance",
new List<PropertyCondition>
{
new PropVerify_IsNotEmpty(),
new PropVerify_IsOnGeoLod(),
new PropVerify_IsNumber()
}
},
{
"explosionshielding",
new List<PropertyCondition>
{
new PropVerify_IsNotEmpty(),
new PropVerify_IsOnGeoLod(),
new PropVerify_IsNumber()
}
},
{
"forcenotalpha",
CreateBooleanCondition(true)
},
{
"frequent",
CreateBooleanCondition(true)
},
{
"keyframe",
CreateBooleanCondition(true)
},
{
"viewdensitycoef",
new List<PropertyCondition>
{
new PropVerify_IsNotEmpty(), //#TODO make a CreateNumberCondition utility function for these
new PropVerify_IsOnGeoLod(),
new PropVerify_IsNumber()
}
},
{
"loddensitycoef",
new List<PropertyCondition>
{
new PropVerify_IsNotEmpty(), //#TODO make a CreateNumberCondition utility function for these
new PropVerify_IsOnGeoLod(),
new PropVerify_IsNumber()
}
},
{
"lodnoshadow",
new List<PropertyCondition>
{
new PropVerify_IsNotEmpty(),
new PropVerify_IsBoolean(),
new PropVerify_IsOnVisLod()
}
},
{
"map",
new List<PropertyCondition>
{
new PropVerify_IsNotEmpty(),
new PropVerify_IsOnGeoLod(),
new PropVerify_IsEnum(
new HashSet<string>
{
"tree",
"small tree",
"bush",
"building",
"house",
"forest border",
"forest triangle",
"forest square",
"church",
"chapel",
"cross",
"rock",
"bunker",
"fortress",
"fountain",
"view-tower",
"lighthouse",
"quay",
"fuelstation",
"hospital",
"fence",
"wall",
"hide",
"busstop",
"road",
"forest",
"transmitter",
"stack",
"ruin",
"tourism",
"watertower",
"track",
"main road",
"rocks",
"power lines",
"railway",
"powersolar",
"powerwave",
"powerwind",
"shipwreck",
"trail",
"forest_lod1",
"forest_lod2",
"town_lod1" //List as of version 1.88
})
}
},
{
"mass",
new List<PropertyCondition>
{
new PropVerify_IsNotEmpty(), //#TODO make a CreateNumberCondition utility function for these
new PropVerify_IsOnGeoLod(),
new PropVerify_IsNumber()
}
},
{
"placement",
new List<PropertyCondition>
{
new PropVerify_IsNotEmpty(),
new PropVerify_IsOnGeoLod(),
new PropVerify_IsEnum(
new HashSet<string>
{
"slope",
"slopex",
"slopez",
"slopelandcontact"
})
}
},
{
"prefershadowvolume",
CreateBooleanCondition(true)
},
{
"sbsource",
new List<PropertyCondition>
{
new PropVerify_IsNotEmpty(),
new PropVerify_IsOnGeoLod(),
new PropVerify_IsEnum(
new HashSet<string>
{
"explicit",
"none",
"shadow",
"shadowvolume",
"visual",
"visualex"
})
}
},
{
"shadow",
new List<PropertyCondition>
{
new PropVerify_IsNotEmpty(),
new PropVerify_IsOnGeoLod(),
new PropVerify_ExpectPropertyNotExist("sbsource"),
new PropVerify_IsEnum(
new HashSet<string>
{
"hybrid"
})
}
},
{
"shadowlod",
new List<PropertyCondition>
{
new PropVerify_IsNotEmpty(),
new PropVerify_IsOnGeoLod(),
new PropVerify_ObsoleteValue("-1"), //-1 is already default if undefined
new PropVerify_LogicOr(
new PropVerify_IsLodIndex(11000, true),
new PropVerify_IsLodIndex(10000, true)
//This is fallback in case the others are not defined, so this can be either.
)
}
},
{
"shadowvolumelod",
new List<PropertyCondition>
{
new PropVerify_IsNotEmpty(),
new PropVerify_IsOnGeoLod(),
new PropVerify_ObsoleteValue("-1"), //-1 is already default if undefined
new PropVerify_IsLodIndex(10000, true)
}
},
{
"shadowbufferlod",
new List<PropertyCondition>
{
new PropVerify_IsNotEmpty(),
new PropVerify_IsOnGeoLod(),
new PropVerify_ObsoleteValue("-1"), //-1 is already default if undefined
new PropVerify_LogicOr(
new PropVerify_IsLodIndex(11000, true),
new PropVerify_IsLodIndex(10000, true)
//There is a bug in OB where shadowBuffer 0 would be displayed as
// "shadowVolume 1000"
)
}
},
{
"shadowbufferlodvis",
new List<PropertyCondition>
{
new PropVerify_IsNotEmpty(),
new PropVerify_IsOnGeoLod(),
new PropVerify_ObsoleteValue("-1"), //-1 is already default if undefined
new PropVerify_LogicOr(
new PropVerify_IsLodIndex(11000, true),
new PropVerify_IsLodIndex(10000, true)
//There is a bug in OB where shadowBuffer 0 would be displayed as
// "shadowVolume 1000"
)
//#TODO verify hat the lod index is < than minShadow. Only vis
}
},
{
"shadowoffset",
new List<PropertyCondition>
{
new PropVerify_IsNotEmpty(), //#TODO make a CreateNumberCondition utility function for these
new PropVerify_IsOnGeoLod(),
new PropVerify_IsNumber()
//#TODO I think we should set reasonable limits here. Only small values really make sense
}
}
};
public static void verifyModel(ref Model model)
{
foreach (var lod in model.lods)
{
foreach (var property in lod.Value.properties)
{
if (!verifiers.ContainsKey(property.Key))
{
lod.Value.propertyExceptions.Add(new PropertyException(property.Key, "Unknown Property", false));
continue;
}
//#TODO detect potential typo's here by checking how big the difference to the known values is
var tuple = new Tuple<string, string>(property.Key, property.Value.value);
foreach (var condition in verifiers[property.Key])
{
try
{
condition.verifyProperty(model, tuple, lod.Value);
} catch (PropertyException exception) { lod.Value.propertyExceptions.Add(exception); }
}
}
}
}
}
}